Add gas-bound test for atomic_close_period asserting linear-in-holders cost bound

[thlpkee20-wq]

Description

Once atomic_close_period lands, its gas should remain O(holders) without hidden quadratic paths. Add a gas-bound test parameterized by 1, 10, 100, 1_000 holders asserting the cpu_insn budget grows linearly within tolerance.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Relevant code: Revora-Contracts/src/test_close_period.rs
• Linearity check uses env.cost_estimate().budget() snapshots

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/atomic-close-period-gas-linearity
• Implement changes
  • Parameterize over holder counts via a helper
  • Fit a line and assert R^2 > 0.98 for cpu_insn vs holders
  • Document tolerance and fail-mode in MULTISIG_GAS_TEST_SUMMARY.md style
• Validate security and correctness assumptions

Test and commit

• Run tests
  • cargo test --all
• Cover edge cases
  • Zero-holder offering must close with bounded constant cost
• Include test output and security notes

Example commit message

test: assert atomic_close_period gas grows linearly with holders

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[Hunter-baddie]

@Hunter-baddie has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Please can I be assigned this issue to work on?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Hunter-baddie to this issue.

[bbjiggy]

@bbjiggy has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi, I'd like to work on this issue.

My approach would be to add a parameterized gas-bound test that measures cpu_insn consumption for atomic_close_period across holder counts of 0, 1, 10, 100, and 1,000 using env.cost_estimate().budget() snapshots. I'll refactor the test setup into reusable helpers to keep the implementation clean and easy to review, then fit a linear regression over the collected data and assert an R² > 0.98 to detect any hidden quadratic behavior. I'll also verify that the zero-holder case completes with bounded constant cost, document the tolerance and failure criteria following the existing MULTISIG_GAS_TEST_SUMMARY.md style, and run cargo test --all with comprehensive security notes and test output included.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bbjiggy to this issue.

[grantfox-oss]

🦊 GrantFox — @Hunter-baddie has been assigned to this issue!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #480)
2. Your PR will be reviewed by the RevoraOrg maintainers

Good luck! Track your progress on GrantFox.

[drips-wave]

Congratulations, @Hunter-baddie! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Hunter-baddie: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊