We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As documented in #134, type inference based on documented types is weak.
In practice, we want to detect type variance changes for complex types, such as @var Foo<Bar, Baz>.
@var Foo<Bar, Baz>
We also want to detect changes such as:
function foo() { - return 1; + return 'foo'; }
These types are currently not inferred (BC check completely skipped), and that is a problem.
I think @psalm could help with this, but need to inspect further.
The text was updated successfully, but these errors were encountered:
Fqsen
As discussed with @muglug, there is some internal API in Psalm that could be helpful here (but is not covered by BC yet):
there’s this method for params: https://github.com/vimeo/psalm/blob/210a0fc98d0d905394ff23e2ee2be6a1090cbac6/src/Psalm/Internal/Codebase/Methods.php#L294-L305 and this method for method return types: https://github.com/vimeo/psalm/blob/210a0fc98d0d905394ff23e2ee2be6a1090cbac6/src/Psalm/Internal/Codebase/Methods.php#L531-L538 and this for property types: https://github.com/vimeo/psalm/blob/210a0fc98d0d905394ff23e2ee2be6a1090cbac6/src/Psalm/Internal/Codebase/Properties.php#L225-L235
Sorry, something went wrong.
No branches or pull requests
As documented in #134, type inference based on documented types is weak.
In practice, we want to detect type variance changes for complex types, such as
@var Foo<Bar, Baz>
.We also want to detect changes such as:
These types are currently not inferred (BC check completely skipped), and that is a problem.
I think @psalm could help with this, but need to inspect further.
The text was updated successfully, but these errors were encountered: