Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phar release is not created #374

Open
asgrim opened this issue Dec 26, 2021 · 7 comments · May be fixed by #522
Open

Phar release is not created #374

asgrim opened this issue Dec 26, 2021 · 7 comments · May be fixed by #522

Comments

@asgrim
Copy link
Member

asgrim commented Dec 26, 2021

As per:

https://twitter.com/s_bergmann/status/1475014835129757699

Looks like the "release-phar" action did not run (can't verify, I'm on phone)

It should be triggered by creating the release. However, my guess is that because we're using laminas/automatic-releases, downstream events are not triggered due to the GitHub access token being used. It might be possible to switch this out to use the personal access token for the organisation, which would cause downstream events to trigger actions in turn.

https://docs.github.com/en/actions/reference/authentication-in-a-workflow#using-the-github_token-in-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

@asgrim asgrim added the bug label Dec 26, 2021
@Ocramius
Copy link
Member

The token for the release is mine though: we should be fine.

We could copy https://github.com/maglnet/ComposerRequireChecker/blob/28d7833f000667fd90ae2d38b19cf670593af190/.github/workflows/phar-creation.yml to fix this.

@Ocramius Ocramius modified the milestones: 5.0.1, 6.0.1 Dec 26, 2021
@Ocramius Ocramius modified the milestones: 6.0.1, 6.1.0 Jan 3, 2022
@Ocramius Ocramius removed this from the 6.1.0 milestone Jan 15, 2022
@sebastianbergmann
Copy link

Sorry for bothering: ping.

@asgrim asgrim linked a pull request May 22, 2022 that will close this issue
@Legion112
Copy link
Contributor

Should phar be attached release asset here?
When I will have time I might be willing to help to debug this one.
image

@sebastianbergmann
Copy link

Should phar be attached release asset here?

Yes, please. This is where Psalm, for instance, publishes their PHARs: https://github.com/vimeo/psalm/releases/tag/5.6.0

@sebastianbergmann
Copy link

Any update on this? Thanks!

@Ocramius
Copy link
Member

Ocramius commented Dec 5, 2023

Nobody worked on Phar releases anymore, sorry: unlikely happening unless someone else proposes a patch for it.

@drupol
Copy link
Contributor

drupol commented Dec 5, 2023

Just made a proposal using Nix at #754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants