Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error output from Psalm as part of report about each killed mutant. #485

Open
bdsl opened this issue Nov 17, 2023 · 2 comments
Open

Comments

@bdsl
Copy link

bdsl commented Nov 17, 2023

When a mutant is killed by PHPUnit the output from PHPUnit is included in some of the reports Infection generates, which is helpful to understand how the test relates to the mutant. Currently when a mutant is killed by a Psalm check the output field is left blank.

I think it would be useful to be able to see the message(s) from Psalm in the report, and fairly straightforward to implement that inside this plugin's code. I actually did a rough version of it on my copy which is how I learned about issue #484 .

I'll try and make a PR for this if maintainers her think it would be useful.

@Ocramius
Copy link
Member

Currently when a mutant is killed by a Psalm check the output field is left blank.

I don't think output capturing was part of the upstream project when this was designed, so do feel free to introduce it 👍

@bdsl
Copy link
Author

bdsl commented Nov 17, 2023

Thanks, I'll try and make a PR in the next few days or weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants