Add timestamp to fouls to make invalid goal detection work

Author: g3force

internal/app/state/teaminfo.go

@@ -2,6 +2,7 @@ package state
 
 import (
 	"google.golang.org/protobuf/types/known/durationpb"
+	"google.golang.org/protobuf/types/known/timestamppb"
 	"time"
 )
 
@@ -59,15 +60,17 @@ func (x *TeamInfo) AddRedCard(causedByGameEvent *GameEvent) {
 }
 
 // AddFoul adds a new foul to the team
-func (x *TeamInfo) AddFoul(causedByGameEvent *GameEvent) {
+func (x *TeamInfo) AddFoul(causedByGameEvent *GameEvent, ts time.Time) {
 	id := uint32(0)
-	numCards := len(x.Fouls)
-	if numCards > 0 {
-		id = *x.Fouls[numCards-1].Id + 1
+	numFouls := len(x.Fouls)
+	if numFouls > 0 {
+		id = *x.Fouls[numFouls-1].Id + 1
 	}
+	timestamp := timestamppb.New(ts)
 	x.Fouls = append(x.Fouls, &Foul{
 		Id:                &id,
 		CausedByGameEvent: causedByGameEvent,
+		Timestamp:         timestamp,
 	})
 	return
 }

internal/app/statemachine/change_gameevent.go

@@ -38,7 +38,7 @@ func (s *StateMachine) processChangeAddGameEvent(newState *state.State, change *
 		for _, team := range state.BothTeams() {
 			if byTeam == state.Team_UNKNOWN || byTeam == team {
 				log.Printf("Team %v got a foul for %v", byTeam, gameEvent)
-				newState.TeamInfo(team).AddFoul(gameEvent)
+				newState.TeamInfo(team).AddFoul(gameEvent, s.timeProvider())
 				numFouls := len(newState.TeamInfo(team).Fouls)
 				if numFouls%3 == 0 {
 					var causedGameEvents []*state.GameEvent