Avoid getting stuck due to missing ball placement command

It is currently possible, especially during dribble fouls, that the ball is still within the 1m radius where no ball placement is required. But if it is moving, it can get out of this radius. Currently, the check for ball placement is only done immediately after the STOP command. So the game is stuck in a situation, where ball placement is required, but no command is sent.

Author: g3force

internal/app/engine/process_runningtostop.go

@@ -12,13 +12,15 @@ func (e *Engine) processRunningToStop() {
 	}
 
 	if e.ballPlacementRequired() {
-		log.Printf("Ball placement is needed")
+		log.Printf("Running -> Stop: Ball placement is needed")
 		e.Enqueue(&statemachine.Change{
 			Origin: &changeOriginEngine,
 			Change: &statemachine.Change_StartBallPlacement{
 				StartBallPlacement: &statemachine.StartBallPlacement{},
 			},
 		})
+	} else {
+		log.Printf("Running -> Stop: No ball placement needed")
 	}
 }
 
@@ -27,6 +29,13 @@ func (e *Engine) ballPlacementRequired() bool {
 		// fallback if the fields are not set
 		return false
 	}
+
+	// The ball is stationary.
+	// Else, checking the following position checks make no sense, as the ball may roll out of or in those
+	if !e.ballSteady() {
+		return true
+	}
+
 	placementPos := e.currentState.PlacementPos
 	ballPos := e.gcState.TrackerStateGc.Ball.Pos.ToVector2()
 
@@ -50,10 +59,5 @@ func (e *Engine) ballPlacementRequired() bool {
 		}
 	}
 
-	// The ball is stationary.
-	if !e.ballSteady() {
-		return true
-	}
-
 	return false
 }

proto/ssl_gc_engine.proto

@@ -21,12 +21,12 @@ message GcState {
 
     // can the match be continued right now?
     optional bool ready_to_continue = 5;
-    
+
     // list of issues that hinders the game from continuing
     repeated string continuation_issues = 6;
 }
 
-// The GC state for a singl eteam
+// The GC state for a single team
 message GcStateTeam {
     // true: The team is connected
     optional bool connected = 1;