-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider exporting @data
from Moshi.Data
and @match
from Moshi.Match
#18
Comments
I really disagree with the idea of not exporting things. IMO, expected APIs should be exported because it's very useful for the REPL and other interactive use-cases. It should be the responsibility of packages to avoid regular using and instead write things like using Moshi.Data: Data, @data Also, we don't need to necessarily export |
I'm afraid I have to disagree with this. People are lazy by default. Exporting things by default would encourage downstream package authors to write a lot of I do not see Moshi serving primarily for REPL. I build the package for more serious and much larger projects. It makes sense for a package primary serve for low-code development and notebook to export a lot of things by default, which is when Thus I have to insist on the idea of no export by default unless extra words are being typed for a developer focused package like Moshi. And I believe See how interfaces are created here: https://github.com/Roger-luo/Jieko.jl |
I think it'd be good if by default
Moshi.Data
exported@data
andMoshi.Match
exported@match
. Then a user in the REPL can quickly write in one lineThis way,
@data
and@match
still aren't exported fromMoshi
itself by default, but there's an easy way to bring them into the namespace with less typing.The text was updated successfully, but these errors were encountered: