storeDiffContent,: Cached content remained in memory

- Without accepting/rejecting, in storeDiffContent, the cached before/after content remained in memory for the entire session.
    1. Add document close listener in FcoTextDocumentContentProvider:
      - Listen for vscode.workspace.onDidCloseTextDocument events
      - Filter for fco-diff scheme URIs
      - Extract file path from closed URIs and call cleanupFile()
    2. Add tab close listener as backup:
      - Listen for vscode.window.tabGroups.onDidChangeTabs events
      - Detect when FCO diff tabs are closed
      - Clean up associated content
    3. Update provider registration:
      - Register event listeners when provider is created
      - Properly dispose listeners when provider is disposed
    4. Add helper method:
      - extractFilePathFromUri() to reverse-engineer file paths from hash-based URIs
      - Handle edge cases where URI-to-file mapping is lost

Author: playcations

src/extension.ts

@@ -364,6 +364,10 @@ export async function deactivate() {
 		await bridge.disconnect()
 	}
 
+	// Dispose FCO content provider to clean up event listeners
+	const fcoContentProvider = FcoTextDocumentContentProvider.getInstance()
+	fcoContentProvider.dispose()
+
 	await McpServerManager.cleanup(extensionContext)
 	TelemetryService.instance.shutdown()
 	TerminalRegistry.cleanup()

src/services/files-changed/FcoTextDocumentContentProvider.ts

@@ -8,6 +8,11 @@ export class FcoTextDocumentContentProvider implements vscode.TextDocumentConten
 	private contentStore = new Map<string, string>()
 	private fileToUriMapping = new Map<string, { beforeUri: string; afterUri: string }>()
 	private static instance: FcoTextDocumentContentProvider
+	private disposables: vscode.Disposable[] = []
+
+	constructor() {
+		this.setupEventListeners()
+	}
 
 	static getInstance(): FcoTextDocumentContentProvider {
 		if (!this.instance) {
@@ -16,6 +21,67 @@ export class FcoTextDocumentContentProvider implements vscode.TextDocumentConten
 		return this.instance
 	}
 
+	/**
+	 * Set up event listeners for automatic cleanup when diff documents are closed
+	 */
+	private setupEventListeners(): void {
+		// Listen for document close events to automatically clean up fco-diff content
+		const onDocumentClose = vscode.workspace.onDidCloseTextDocument((document) => {
+			if (document.uri.scheme === "fco-diff") {
+				const filePath = this.extractFilePathFromUri(document.uri.toString())
+				if (filePath) {
+					this.cleanupFile(filePath)
+				}
+			}
+		})
+		this.disposables.push(onDocumentClose)
+
+		// Listen for tab close events as backup cleanup method
+		const onTabChange = vscode.window.tabGroups.onDidChangeTabs((event) => {
+			for (const tab of event.closed) {
+				if (tab.input instanceof vscode.TabInputTextDiff) {
+					const originalUri = tab.input.original
+					const modifiedUri = tab.input.modified
+
+					// Check if either URI is an fco-diff scheme
+					if (originalUri?.scheme === "fco-diff" || modifiedUri?.scheme === "fco-diff") {
+						// Try to extract file path from the tab label or URI
+						const filePath = this.extractFilePathFromTabInput(tab.input)
+						if (filePath) {
+							this.cleanupFile(filePath)
+						}
+					}
+				}
+			}
+		})
+		this.disposables.push(onTabChange)
+	}
+
+	/**
+	 * Extract the original file path from an fco-diff URI
+	 * Uses reverse lookup through fileToUriMapping to find the associated file path
+	 */
+	private extractFilePathFromUri(uriString: string): string | undefined {
+		// Direct lookup - find file path that maps to this URI
+		for (const [filePath, uris] of this.fileToUriMapping.entries()) {
+			if (uris.beforeUri === uriString || uris.afterUri === uriString) {
+				return filePath
+			}
+		}
+		return undefined
+	}
+
+	/**
+	 * Extract file path from tab input for cleanup purposes
+	 */
+	private extractFilePathFromTabInput(tabInput: vscode.TabInputTextDiff): string | undefined {
+		const originalUri = tabInput.original?.toString()
+		const modifiedUri = tabInput.modified?.toString()
+
+		// Try to extract from either URI
+		return this.extractFilePathFromUri(originalUri || "") || this.extractFilePathFromUri(modifiedUri || "")
+	}
+
 	/**
 	 * Provides text document content for FCO diff URIs.
 	 * Called by VS Code when it needs the actual content for a URI.
@@ -129,4 +195,13 @@ export class FcoTextDocumentContentProvider implements vscode.TextDocumentConten
 		this.contentStore.clear()
 		this.fileToUriMapping.clear()
 	}
+
+	/**
+	 * Dispose of event listeners and clean up resources
+	 */
+	dispose(): void {
+		this.disposables.forEach((disposable) => disposable.dispose())
+		this.disposables = []
+		this.clearAll()
+	}
 }