Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diigolet can't be dropped into Favicon Bar? #16

Open
Ryanrpm opened this issue Jul 3, 2016 · 3 comments
Open

Diigolet can't be dropped into Favicon Bar? #16

Ryanrpm opened this issue Jul 3, 2016 · 3 comments

Comments

@Ryanrpm
Copy link

Ryanrpm commented Jul 3, 2016

First off, thank you for creating this Favicon Bar for Safari!!

There is only one issue I've found with it though. Apparently, the Diigolet link has several semicolons throughout it and when dropped into the Favicon bar it gets broken up into 3 or 4 different broken favicons. :( Please help.

If I could do away with my bookmarks bar and only keep the Favicon bar, I would! But for now I have to keep both because of Diigolet. See picture.
favicon and bookmark bar

@RoryCombe
Copy link
Owner

Glad you like the extension. Currently the bar isn't designed to be used with Javascript bookmarklets like the Diigolet. Unfortunately I don't have the time at the moment to implement the changes that would support Javascript links.

I'm assuming you aren't a programmer that would be willing to contribute and code up the changes needed. If I'm wrong, I'd be more than happy to brief you on what needs to be done.

@Ryanrpm
Copy link
Author

Ryanrpm commented Jul 9, 2016

You are correct, I’m not a programmer. I’ll just have to be patient until you have the time to make the changes to work with Javascript links Thanks for all you have done…you’ve made using Safari more enjoyable and user friendly!

Ryan

On Jul 6, 2016, at 5:37 AM, umfana [email protected] wrote:

Glad you like the extension. Currently the bar isn't designed to be used with Javascript bookmarklets like the Diigolet. Unfortunately I don't have the time at the moment to implement the changes that would support Javascript links.

I'm assuming you aren't a programmer that would be willing to contribute and code up the changes needed. If I'm wrong, I'd be more than happy to brief you on what needs to be done.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #16 (comment), or mute the thread https://github.com/notifications/unsubscribe/ATVB2aKkCWVl1nWQ4oapGP0FF4w7Ygj2ks5qS6FvgaJpZM4JD4Rm.

@popcornhax
Copy link
Collaborator

I've got this on my todo list for a future release but I'm not 100% sure it can be done. We'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants