Skip to content

Commit 5cd0c43

Browse files
committed
chore(deps): take the dev-minor group, and the playwright block was a stale lockfile
The dev-minor dependabot PR had been parked on the belief that @playwright/test 1.61.1 forces two playwright-core copies, whose Page types are not assignable to each other, breaking typecheck. That is real in the PR but it is an artifact of dependabot patching the lockfile in place: @axe-core/playwright declares playwright-core as a PEER, and the incremental update left the old 1.59.1 peer entry behind next to the new 1.61.1 one. A clean resolve produces exactly one playwright-core. There was no upstream conflict to wait on. Dependabot could not have landed this on its own regardless: the browser binaries come from a PINNED mcr.microsoft.com/playwright image tag in ci.yml and release.yml, and nothing teaches dependabot that the tag has to move with the library. Both are now on v1.61.1-noble. Verified on the real bump, not asserted: typecheck (the exact failure) clean, 306 unit, 18 e2e including axe-core a11y in light and dark, and the audit.
1 parent d1891c9 commit 5cd0c43

4 files changed

Lines changed: 156 additions & 164 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ jobs:
4141
# Pull the exact matching browsers from the official Playwright image on
4242
# Microsoft Container Registry, then copy them into the default browser
4343
# cache. install-deps is apt-only (no CDN download). Keep the image tag
44-
# in lockstep with @playwright/test in package.json (currently 1.59.1).
44+
# in lockstep with @playwright/test in package.json (currently 1.61.1).
4545
run: |
4646
bunx playwright install-deps chromium
47-
docker create --name pwbrowsers mcr.microsoft.com/playwright:v1.59.1-noble
47+
docker create --name pwbrowsers mcr.microsoft.com/playwright:v1.61.1-noble
4848
mkdir -p "$HOME/.cache/ms-playwright"
4949
docker cp pwbrowsers:/ms-playwright/. "$HOME/.cache/ms-playwright/"
5050
docker rm pwbrowsers

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,10 @@ jobs:
111111
# browsers from the official Playwright image on Microsoft Container
112112
# Registry instead, then copy them into the default browser cache.
113113
# install-deps is apt-only (no CDN download). Keep the image tag in
114-
# lockstep with @playwright/test in package.json (currently 1.59.1).
114+
# lockstep with @playwright/test in package.json (currently 1.61.1).
115115
run: |
116116
bunx playwright install-deps
117-
docker create --name pwbrowsers mcr.microsoft.com/playwright:v1.59.1-noble
117+
docker create --name pwbrowsers mcr.microsoft.com/playwright:v1.61.1-noble
118118
mkdir -p "$HOME/.cache/ms-playwright"
119119
docker cp pwbrowsers:/ms-playwright/. "$HOME/.cache/ms-playwright/"
120120
docker rm pwbrowsers

0 commit comments

Comments
 (0)