scripts: modify-return.sh: use getopt

$ ./modify-return.sh -p $(pidof return) --addr 0x4006d4

Signed-off-by: Rong Tao <[email protected]>

Author: Rtoax

scripts/modify-return.sh

@@ -5,6 +5,7 @@ set -e
 PID=
 GDB=$(which gdb 2>/dev/null || :)
 ADDRESS=
+verbose=
 
 if [[ -z ${GDB} ]]; then
 	echo >&2 "ERROR: Need gdb"
@@ -16,25 +17,70 @@ if [[ $(uname -m) != aarch64 ]]; then
 	exit 1
 fi
 
-usage()
-{
+__usage__() {
 	echo "
-modify-address.sh <PID> <ADDRESS>
+modify-return [-p <PID>] [--address <ADDRESS>]
+
+-p, --pid  [PID]        specify pid
+-a, --address [ADDRESS] specify address to modify
+-v, --verbose           set -x
+-h, --help              print this info
 "
+	exit ${1-0}
 }
 
-PID=$1
-shift 1
-ADDRESS=$1
+TEMP=$(getopt \
+	--options p:a:vh \
+	--long pid: \
+	--long address: \
+	--long verbose \
+	--long help \
+	-n modify-return -- "$@")
+
+test $? != 0 && __usage__ 1
+
+eval set -- "$TEMP"
+
+while true; do
+	case $1 in
+	-p|--pid)
+		shift
+		PID=$1
+		if ! [[ -d /proc/${PID} ]]; then
+			echo >&2 "ERROR: PID=${PID} is not exist."
+			exit 1
+		fi
+		shift
+		;;
+	-a|--address)
+		shift
+		ADDRESS=$1
+		shift
+		;;
+	-v|--verbose)
+		shift
+		set -x
+		verbose=yes
+		;;
+	-h|--help)
+		shift
+		__usage__
+		;;
+	--)
+		shift
+		break
+		;;
+	esac
+done
 
 if [[ -z ${PID} ]]; then
-	usage
+	__usage__
 	echo >&2 "ERROR: Need pass PID"
 	exit 1
 fi
 
 if [[ -z ${ADDRESS} ]] || [[ ${ADDRESS:0:2} != 0x ]]; then
-	usage
+	__usage__
 	echo >&2 "ERROR: Must pass a address with 0x prefix"
 	exit 1
 fi

tests/hello/test.sh

@@ -46,6 +46,10 @@ while true; do
 	-p|--pid)
 		shift
 		pid=$1
+		if ! [[ -d /proc/${pid} ]]; then
+			echo >&2 "ERROR: PID=${pid} is not exist."
+			exit 1
+		fi
 		shift
 		;;
 	-u|--patch)