Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make from_errno use try_from_errno #1125

Open
ojeda opened this issue Oct 7, 2024 · 6 comments
Open

Make from_errno use try_from_errno #1125

ojeda opened this issue Oct 7, 2024 · 6 comments
Labels
easy Expected to be an easy issue to resolve. good first issue Good for newcomers • lib Related to the `rust/` library.

Comments

@ojeda
Copy link
Member

ojeda commented Oct 7, 2024 •
edited
Loading

Make from_errno use try_from_errno (available in rust-next).

This also allows to remove unsafe code and a comment or two too.

This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag and a Link: tag to this issue. Please see https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.
@ojeda ojeda added good first issue Good for newcomers easy Expected to be an easy issue to resolve. labels Oct 7, 2024
@cristiangabor
Copy link

I am new to the Kernel development process and I would like to participate if is possible.

@ojeda
Copy link
Member Author

ojeda commented Oct 8, 2024

Sure, please go ahead!

@haveheartt
Copy link

Hello, is this issue still available ? I would like to participate if possible.

@ojeda
Copy link
Member Author

ojeda commented Nov 4, 2024

I think we didn't get a patch from @cristiangabor yet -- Cristian, do you plan to send it? Thanks!

@cristiangabor
Copy link

Unfortunately I did not made the fix. @haveheartt please go ahead with the implementation!

@ojeda
Copy link
Member Author

ojeda commented Nov 5, 2024

https://lore.kernel.org/rust-for-linux/[email protected]/
https://lore.kernel.org/rust-for-linux/[email protected]/
https://lore.kernel.org/rust-for-linux/[email protected]/

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Nov 25, 2024
@wutchzone @intel-lab-lkp
rust: error: modify from_errno to use try_from_errno
35b5c7d 
Modify the from_errno function to use try_from_errno to
reduce code duplication while still maintaining all existing
behavior and error handling and also reduces unsafe code.

Link: Rust-for-Linux#1125
Suggested-by:  Miguel Ojeda <[email protected]>
Co-developed-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Daniel Sedlak <[email protected]>
@ojeda ojeda added the • lib Related to the `rust/` library. label Nov 25, 2024
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Dec 7, 2024
@wutchzone @intel-lab-lkp
rust: error: modify from_errno to use try_from_errno
74f2726 
Modify the from_errno function to use try_from_errno to
reduce code duplication while still maintaining all existing
behavior and error handling and also reduces unsafe code.

Link: Rust-for-Linux#1125
Suggested-by:  Miguel Ojeda <[email protected]>
Co-developed-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Daniel Sedlak <[email protected]>
ojeda pushed a commit that referenced this issue Dec 17, 2024
@wutchzone @ojeda
rust: error: modify from_errno to use try_from_errno
9a02cbc 
Modify the from_errno function to use try_from_errno to
reduce code duplication while still maintaining all existing
behavior and error handling and also reduces unsafe code.

Link: #1125
Suggested-by: Miguel Ojeda <[email protected]>
Co-developed-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Daniel Sedlak <[email protected]>
Reviewed-by: Fiona Behrens <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
senekor pushed a commit to senekor/linux that referenced this issue Feb 15, 2025
@wutchzone @senekor
rust: error: modify from_errno to use try_from_errno
42cdb29 
Modify the from_errno function to use try_from_errno to
reduce code duplication while still maintaining all existing
behavior and error handling and also reduces unsafe code.

Link: Rust-for-Linux#1125
Suggested-by: Miguel Ojeda <[email protected]>
Co-developed-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Daniel Sedlak <[email protected]>
Reviewed-by: Fiona Behrens <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
jannau pushed a commit to AsahiLinux/linux that referenced this issue Mar 1, 2025
@wutchzone @jannau
rust: error: modify from_errno to use try_from_errno
3f7cbe8 
Modify the from_errno function to use try_from_errno to
reduce code duplication while still maintaining all existing
behavior and error handling and also reduces unsafe code.

Link: Rust-for-Linux#1125
Suggested-by: Miguel Ojeda <[email protected]>
Co-developed-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Guilherme Augusto Martins da Silva <[email protected]>
Signed-off-by: Daniel Sedlak <[email protected]>
Reviewed-by: Fiona Behrens <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Expected to be an easy issue to resolve. good first issue Good for newcomers • lib Related to the `rust/` library.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ojeda @cristiangabor @haveheartt