forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 476
Closed
Labels
• kbuildRelated to building the kernel, `make`, `Kbuild`, `Kconfig` options...Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...
Description
Since PR rust-lang/rust#138162, the Rust std
library and core
libraries use edition 2024. The Linux makefile hardcodes edition 2021 however.
Right now, core compiles fine on editions 2021 and 2024, but my PR rust-lang/rust#140966 encountered a build failure of the rust-for-linux CI.
Talked to @nbdd0121 about this. According to them, it should be possible to add conditional compilation dependent on the rust compiler used to compile the kernel. This matches the expectations of the core
library the most I'd say: on releases before 1.87.0, the compiler used edition 2021, and on 1.87.0 and later, it uses 2024.
cc @ehuss
Metadata
Metadata
Assignees
Labels
• kbuildRelated to building the kernel, `make`, `Kbuild`, `Kconfig` options...Related to building the kernel, `make`, `Kbuild`, `Kconfig` options...
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
rust: compile libcore with edition 2024 for 1.87+
ojeda commentedon May 18, 2025
Yeah, that shouldn't be a problem -- it is the way we handle this sort of thing (Gary asked me while at RustWeek).
Thanks for filling the issue!
nbdd0121 commentedon May 18, 2025
lore: https://lore.kernel.org/rust-for-linux/20250517085600.2857460-1-gary@garyguo.net/T/#u
tgross35 commentedon May 18, 2025
@est31 did you leave a comment somewhere about something special needed for rustdoc? I thought it was on 21e9042, but I can't find it anywhere now.
est31 commentedon May 18, 2025
Yeah you remember correctly. I've deleted that comment after @nbdd0121 pointed out to me that there is a
skip_flags
. The patch looks fine to me, but still need try rustc with the patch.rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
Auto merge of #141415 - est31:let_chains_libcore, r=tgross35
Auto merge of #141415 - est31:let_chains_libcore, r=tgross35
7 remaining items
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+
rust: compile libcore with edition 2024 for 1.87+