Skip to content

conditional passing of edition for core #1163

@est31

Description

@est31

Since PR rust-lang/rust#138162, the Rust std library and core libraries use edition 2024. The Linux makefile hardcodes edition 2021 however.

Right now, core compiles fine on editions 2021 and 2024, but my PR rust-lang/rust#140966 encountered a build failure of the rust-for-linux CI.

Talked to @nbdd0121 about this. According to them, it should be possible to add conditional compilation dependent on the rust compiler used to compile the kernel. This matches the expectations of the core library the most I'd say: on releases before 1.87.0, the compiler used edition 2021, and on 1.87.0 and later, it uses 2024.

cc @ehuss

Activity

added
• kbuildRelated to building the kernel, `make`, `Kbuild`, `Kconfig` options...
on May 18, 2025
ojeda

ojeda commented on May 18, 2025

@ojeda
Member

According to them, it should be possible to add conditional compilation dependent on the rust compiler used to compile the kernel.

Yeah, that shouldn't be a problem -- it is the way we handle this sort of thing (Gary asked me while at RustWeek).

Thanks for filling the issue!

tgross35

tgross35 commented on May 18, 2025

@tgross35
Collaborator

@est31 did you leave a comment somewhere about something special needed for rustdoc? I thought it was on 21e9042, but I can't find it anywhere now.

est31

est31 commented on May 18, 2025

@est31
Author

@est31 did you leave a comment somewhere about something special needed for rustdoc?

Yeah you remember correctly. I've deleted that comment after @nbdd0121 pointed out to me that there is a skip_flags. The patch looks fine to me, but still need try rustc with the patch.

added a commit that references this issue on May 24, 2025

7 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    • kbuildRelated to building the kernel, `make`, `Kbuild`, `Kconfig` options...

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ojeda@nbdd0121@est31@tgross35

        Issue actions

          conditional passing of edition for core · Issue #1163 · Rust-for-Linux/linux