You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I plan to get these done later today also, and they'll follow the tests as a rough example (but obviously cleaner, easier to understand and commented so users know what's going on).
I plan to add warnings about using Cmov directly, as it would act more of an optimisation barrier if a condition is set to x == y.
I may also add warnings about branching in general, and using the ^ operator where the functions provided by CmovEq aren't adequate (which will be extremely unlikely but still probably worth noting). I'll also briefly explain why using == is bad, but I'm no branching expert so that may require some tweaking.
I'll try to adhere to the RustCrypto example format in order to reduce PR review time, and for consistency.
I think I'll try and get #920 fixed up first though.
The text was updated successfully, but these errors were encountered:
I plan to get these done later today also, and they'll follow the tests as a rough example (but obviously cleaner, easier to understand and commented so users know what's going on).
I plan to add warnings about using
Cmov
directly, as it would act more of an optimisation barrier if a condition is set tox == y
.I may also add warnings about branching in general, and using the
^
operator where the functions provided byCmovEq
aren't adequate (which will be extremely unlikely but still probably worth noting). I'll also briefly explain why using==
is bad, but I'm no branching expert so that may require some tweaking.I'll try to adhere to the RustCrypto example format in order to reduce PR review time, and for consistency.
I think I'll try and get #920 fixed up first though.
The text was updated successfully, but these errors were encountered: