Skip to content

Settings are currently independent of Eclipse workspace #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ConjuringCoffee opened this issue Nov 22, 2023 · 4 comments
Closed

Settings are currently independent of Eclipse workspace #211

ConjuringCoffee opened this issue Nov 22, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ConjuringCoffee
Copy link
Contributor

Hi Jörg-Michael, I set up a new Eclipse today. After I installed the ABAP Cleaner, I noticed that my ABAP Cleaner settings were already there.

This hasn't caused any issues for me yet, but it isn't really consistent with other plugins (like ADT).

I imagine this could be problematic for developers working for multiple companies on the same machine. I imagine they use different Eclipse installations and / or different workspaces for the different companies. They'd always have to make sure to switch their current profile, even if they are using separate workspaces.

@ConjuringCoffee
Copy link
Contributor Author

Also, if someone transfers only their Eclipse installation and workspace to another client, they lose their ABAP Cleaner settings.

They'd have to transfer their data from AppData\Roaming\SAP\ABAP cleaner additionally.

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

generally, I believe it is a good thing for ABAP cleaner to be workspace-independent – imagine someone was working with a dozen workspaces and had to maintain their detailed profile settings 12 times! They would immediately ask for ways to synchronize, compare, transfer, etc. their profiles.

On the other hand, I do get your point that it might be helpful to be able(!) to use different profiles in different workspaces without switching them manually every time. So, my idea would be to keep all profiles and settings in the same central place, but to save the three main Cleanup Settings in a workspace-specific way:

image

This means that all workspaces continue to have access to the same profiles, but if you …

  • open workspace 1 and select the "default" profile and "Latest ABAP Release",
  • then switch to workspace 2 and select the "essential" profile and "ABAP 7.53" there,
  • then switch back to workspace 1, the "default" profile and "Latest ABAP Release" will be automatically selected,
  • then switch to workspace 2 again, the "essential" profile and "ABAP 7.53" will be automatically selected.

Someone who anyway uses the same profile in every workspace, won't notice the change, while someone with dedicated cleanup requirements in each workspace will not need to switch the profile etc. manually anymore. If they wish, they could name their profiles like their workspaces, but that would be up to them to decide.

Similarly, the stand-alone version will get its own, independent Cleanup Settings, if it is used in parallel with the ADT plug-in. The file %APPDATA%\SAP\ABAP cleaner\user\settings\main.cfj will look like this:

{
  "requiredVersion": 1,
  "programVersion": 25,
…
  "workspaceCount": 3,
  "workspaceDir0": "<workspace 1 folder>",
  "lastProfileName0": "default",
  "cleanupRangeExpandMode0": 1,
  "releaseRestriction0": 0,
  "workspaceDir1": "<workspace 2 folder>",
  "lastProfileName1": "essential",
  "cleanupRangeExpandMode1": 1,
  "releaseRestriction1": 753,
  "workspaceDir2": "<standalone exe folder>",
  "lastProfileName2": "yet another profile",
  "cleanupRangeExpandMode2": 2,
  "releaseRestriction2": 758
}

Hope that helps!

Kind regards,
Jörg-Michael

@ConjuringCoffee
Copy link
Contributor Author

Hi Jörg-Michael, that sounds good to me. Thank you!

jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue Apr 12, 2024
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

thanks for your feedback and for this idea – version 1.16.0 will now use workspace-specific cleanup settings!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants