Rearrange local declarations leading to syntax error

[zmsMarc]

Settings: Default

I was working on changes to AbapOpenCheck 06 (https://github.com/larshp/abapOpenChecks/blob/main/src/checks/zcl_aoc_check_06.clas.abap) and noticed a syntax error after AbapCleaner re-ordered the local declarations.

Here's an example with the basic structure before:

And after Cleanup:

Notice the field symbol declaration is now before the data statement it references.

Maybe there needs to be an additional check on usages of LIKE LINE OF.

[jmgrassau]

Hi Marc,

thanks a lot for reporting this! The rule already tries to consider LIKE dependencies, but apparently, it gets confused by the BEGIN OF ... END OF in the DATA chain. As a minimal example to trigger the bug, I found:

  METHOD any_method.
    DATA: BEGIN OF ls_struc,
            comp TYPE i,
          END OF ls_struc,
          lt_table TYPE STANDARD TABLE OF ty_s_any WITH DEFAULT KEY.

    FIELD-SYMBOLS <ls_any> LIKE LINE OF lt_table.

    rv_result = ls_struc-comp + lines( lt_table ) + <ls_any>-comp.
  ENDMETHOD.

Will fix this, of course!

Kind regards,
Jörg-Michael

[jmgrassau]

Hi Marc,

thanks again for this finding! This will be fixed in the next release – the rule now double-checks that a declaration is not moved in front of the declaration it refers to with LIKE.

Kind regards,
Jörg-Michael

[zmsMarc]

Thanks as always for the quick solution!

[jmgrassau]

Hi Marc,

version 1.4.1 was just released and should fix this!

Kind regards,
Jörg-Michael