From 9bf0a8ec5092becaa1f703d8a82a38da8fe84872 Mon Sep 17 00:00:00 2001
From: SHAFFNER7 <stefan.haffner@sap.com>
Date: Thu, 13 Feb 2025 14:03:45 +0100
Subject: [PATCH 1/7] Add files for ADVC

---
 file-formats/advc/advc/README.md              |  5 ++
 file-formats/advc/advc/advc-v1.json           | 66 +++++++++++++++++++
 .../advc/advc/type/zif_aff_advc_v1.intf.abap  | 20 ++++++
 .../advc/advc/type/zif_aff_advc_v1.intf.json  |  7 ++
 4 files changed, 98 insertions(+)
 create mode 100644 file-formats/advc/advc/README.md
 create mode 100644 file-formats/advc/advc/advc-v1.json
 create mode 100644 file-formats/advc/advc/type/zif_aff_advc_v1.intf.abap
 create mode 100644 file-formats/advc/advc/type/zif_aff_advc_v1.intf.json

diff --git a/file-formats/advc/advc/README.md b/file-formats/advc/advc/README.md
new file mode 100644
index 000000000..25733b3df
--- /dev/null
+++ b/file-formats/advc/advc/README.md
@@ -0,0 +1,5 @@
+# ADVC File Format
+
+File | Cardinality | Definition | Schema | Example
+:--- | :--- | :--- | :--- | :---
+`<name>.advc.json` | 1 | [`zif_aff_advc_v1.intf.abap`](./type/zif_aff_advc_v1.intf.abap) | [`advc-v1.json`](./advc-v1.json) | [`z_aff_example_advc.advc.json`](./examples/z_aff_example_advc.advc.json)
diff --git a/file-formats/advc/advc/advc-v1.json b/file-formats/advc/advc/advc-v1.json
new file mode 100644
index 000000000..e5a3d8d01
--- /dev/null
+++ b/file-formats/advc/advc/advc-v1.json
@@ -0,0 +1,66 @@
+{
+  "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/advc/advc-v1.json",
+  "title": "App Variant",
+  "description": "App variant",
+  "type": "object",
+  "properties": {
+    "formatVersion": {
+      "title": "Format Version",
+      "description": "Format version",
+      "type": "string",
+      "const": "1"
+    },
+    "header": {
+      "title": "Header",
+      "description": "Header",
+      "type": "object",
+      "properties": {
+        "description": {
+          "title": "Description",
+          "description": "Description of the ABAP object",
+          "type": "string",
+          "maxLength": 100
+        },
+        "originalLanguage": {
+          "title": "Original Language",
+          "description": "Original language of the ABAP object",
+          "type": "string",
+          "minLength": 2
+        },
+        "abapLanguageVersion": {
+          "title": "ABAP Language Version",
+          "description": "ABAP language version",
+          "type": "string",
+          "enum": [
+            "standard",
+            "keyUser",
+            "cloudDevelopment"
+          ],
+          "enumTitles": [
+            "Standard",
+            "ABAP for Key Users",
+            "ABAP Cloud Development"
+          ],
+          "enumDescriptions": [
+            "Standard",
+            "ABAP for key user extensibility",
+            "ABAP cloud development"
+          ],
+          "default": "standard"
+        }
+      },
+      "additionalProperties": false,
+      "required": [
+        "description",
+        "originalLanguage"
+      ]
+    }
+  },
+  "additionalProperties": false,
+  "required": [
+    "formatVersion",
+    "header"
+  ]
+}
diff --git a/file-formats/advc/advc/type/zif_aff_advc_v1.intf.abap b/file-formats/advc/advc/type/zif_aff_advc_v1.intf.abap
new file mode 100644
index 000000000..3b822df31
--- /dev/null
+++ b/file-formats/advc/advc/type/zif_aff_advc_v1.intf.abap
@@ -0,0 +1,20 @@
+INTERFACE zif_aff_advc_v1
+  PUBLIC.
+
+  TYPES:
+    "! <p class="shorttext">App Variant</p>
+    "! App variant
+    BEGIN OF ty_main,
+      "! <p class="shorttext">Format Version</p>
+      "! Format version
+      "! $required
+      format_version TYPE zif_aff_types_v1=>ty_format_version,
+
+      "! <p class="shorttext">Header</p>
+      "! Header
+      "! $required
+      header         TYPE zif_aff_types_v1=>ty_header_100,
+
+    END OF ty_main.
+
+ENDINTERFACE.
diff --git a/file-formats/advc/advc/type/zif_aff_advc_v1.intf.json b/file-formats/advc/advc/type/zif_aff_advc_v1.intf.json
new file mode 100644
index 000000000..e395a6911
--- /dev/null
+++ b/file-formats/advc/advc/type/zif_aff_advc_v1.intf.json
@@ -0,0 +1,7 @@
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "AFF type for ADVC (cross-client app variant)",
+    "originalLanguage": "en"
+  }
+}

From d82e0739a5076f589ed3fd1805f4b78c852dc9d2 Mon Sep 17 00:00:00 2001
From: SHAFFNER7 <stefan.haffner@sap.com>
Date: Thu, 13 Feb 2025 14:08:58 +0100
Subject: [PATCH 2/7] Add files for ADVC

---
 file-formats/advc/{advc => }/README.md                    | 0
 file-formats/advc/{advc => }/advc-v1.json                 | 0
 file-formats/advc/examples/z_aff_example_advc.advc.json   | 8 ++++++++
 .../advc/{advc => }/type/zif_aff_advc_v1.intf.abap        | 0
 .../advc/{advc => }/type/zif_aff_advc_v1.intf.json        | 0
 5 files changed, 8 insertions(+)
 rename file-formats/advc/{advc => }/README.md (100%)
 rename file-formats/advc/{advc => }/advc-v1.json (100%)
 create mode 100644 file-formats/advc/examples/z_aff_example_advc.advc.json
 rename file-formats/advc/{advc => }/type/zif_aff_advc_v1.intf.abap (100%)
 rename file-formats/advc/{advc => }/type/zif_aff_advc_v1.intf.json (100%)

diff --git a/file-formats/advc/advc/README.md b/file-formats/advc/README.md
similarity index 100%
rename from file-formats/advc/advc/README.md
rename to file-formats/advc/README.md
diff --git a/file-formats/advc/advc/advc-v1.json b/file-formats/advc/advc-v1.json
similarity index 100%
rename from file-formats/advc/advc/advc-v1.json
rename to file-formats/advc/advc-v1.json
diff --git a/file-formats/advc/examples/z_aff_example_advc.advc.json b/file-formats/advc/examples/z_aff_example_advc.advc.json
new file mode 100644
index 000000000..7d216d4db
--- /dev/null
+++ b/file-formats/advc/examples/z_aff_example_advc.advc.json
@@ -0,0 +1,8 @@
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "ADVC Example Object",
+    "originalLanguage": "en",
+    "abapLanguageVersion": "5",
+  }
+}
\ No newline at end of file
diff --git a/file-formats/advc/advc/type/zif_aff_advc_v1.intf.abap b/file-formats/advc/type/zif_aff_advc_v1.intf.abap
similarity index 100%
rename from file-formats/advc/advc/type/zif_aff_advc_v1.intf.abap
rename to file-formats/advc/type/zif_aff_advc_v1.intf.abap
diff --git a/file-formats/advc/advc/type/zif_aff_advc_v1.intf.json b/file-formats/advc/type/zif_aff_advc_v1.intf.json
similarity index 100%
rename from file-formats/advc/advc/type/zif_aff_advc_v1.intf.json
rename to file-formats/advc/type/zif_aff_advc_v1.intf.json

From a8a77c1cd7127677083a4e5ad11edafe51953bf6 Mon Sep 17 00:00:00 2001
From: SHAFFNER7 <stefan.haffner@sap.com>
Date: Thu, 13 Feb 2025 14:10:33 +0100
Subject: [PATCH 3/7] Correct example json

---
 file-formats/advc/examples/z_aff_example_advc.advc.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/file-formats/advc/examples/z_aff_example_advc.advc.json b/file-formats/advc/examples/z_aff_example_advc.advc.json
index 7d216d4db..2e215ac54 100644
--- a/file-formats/advc/examples/z_aff_example_advc.advc.json
+++ b/file-formats/advc/examples/z_aff_example_advc.advc.json
@@ -3,6 +3,6 @@
   "header": {
     "description": "ADVC Example Object",
     "originalLanguage": "en",
-    "abapLanguageVersion": "5",
+    "abapLanguageVersion": "5"
   }
 }
\ No newline at end of file

From cdeabc0eadcc1c677d33123abec45bd0b27186a6 Mon Sep 17 00:00:00 2001
From: SHAFFNER7 <stefan.haffner@sap.com>
Date: Thu, 13 Feb 2025 15:02:17 +0100
Subject: [PATCH 4/7] Update z_aff_example_advc.advc.json

Set correct value for abapLanguageVersion
---
 file-formats/advc/examples/z_aff_example_advc.advc.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/file-formats/advc/examples/z_aff_example_advc.advc.json b/file-formats/advc/examples/z_aff_example_advc.advc.json
index 2e215ac54..8f0c4e957 100644
--- a/file-formats/advc/examples/z_aff_example_advc.advc.json
+++ b/file-formats/advc/examples/z_aff_example_advc.advc.json
@@ -3,6 +3,6 @@
   "header": {
     "description": "ADVC Example Object",
     "originalLanguage": "en",
-    "abapLanguageVersion": "5"
+    "abapLanguageVersion": "cloudDevelopment"
   }
-}
\ No newline at end of file
+}

From 3db20302188a9ee96c4827cfb55e60428af3f06c Mon Sep 17 00:00:00 2001
From: SHAFFNER7 <stefan.haffner@sap.com>
Date: Thu, 13 Feb 2025 15:59:59 +0100
Subject: [PATCH 5/7] Update z_aff_example_advc.advc.json

---
 file-formats/advc/examples/z_aff_example_advc.advc.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/file-formats/advc/examples/z_aff_example_advc.advc.json b/file-formats/advc/examples/z_aff_example_advc.advc.json
index 8f0c4e957..d895195d7 100644
--- a/file-formats/advc/examples/z_aff_example_advc.advc.json
+++ b/file-formats/advc/examples/z_aff_example_advc.advc.json
@@ -3,6 +3,6 @@
   "header": {
     "description": "ADVC Example Object",
     "originalLanguage": "en",
-    "abapLanguageVersion": "cloudDevelopment"
+    "abapLanguageVersion": "5",
   }
 }

From 952f4d4c592d7b1190f201dea35892e0264aab38 Mon Sep 17 00:00:00 2001
From: SHAFFNER7 <stefan.haffner@sap.com>
Date: Thu, 13 Feb 2025 16:41:40 +0100
Subject: [PATCH 6/7] Update z_aff_example_advc.advc.json

---
 file-formats/advc/examples/z_aff_example_advc.advc.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/file-formats/advc/examples/z_aff_example_advc.advc.json b/file-formats/advc/examples/z_aff_example_advc.advc.json
index d895195d7..0f59fa74c 100644
--- a/file-formats/advc/examples/z_aff_example_advc.advc.json
+++ b/file-formats/advc/examples/z_aff_example_advc.advc.json
@@ -2,7 +2,6 @@
   "formatVersion": "1",
   "header": {
     "description": "ADVC Example Object",
-    "originalLanguage": "en",
-    "abapLanguageVersion": "5",
+    "originalLanguage": "en"
   }
 }

From 88371cca9aa151f212d5d953c245a9ef4bfcccac Mon Sep 17 00:00:00 2001
From: Michael Schneider <micha.schneider@sap.com>
Date: Fri, 14 Feb 2025 10:41:51 +0100
Subject: [PATCH 7/7] Change line endings of example to `LF`

---
 .../advc/examples/z_aff_example_advc.advc.json     | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/file-formats/advc/examples/z_aff_example_advc.advc.json b/file-formats/advc/examples/z_aff_example_advc.advc.json
index 0f59fa74c..7b6e6777a 100644
--- a/file-formats/advc/examples/z_aff_example_advc.advc.json
+++ b/file-formats/advc/examples/z_aff_example_advc.advc.json
@@ -1,7 +1,7 @@
-{
-  "formatVersion": "1",
-  "header": {
-    "description": "ADVC Example Object",
-    "originalLanguage": "en"
-  }
-}
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "ADVC Example Object",
+    "originalLanguage": "en"
+  }
+}