[House keeping] Fix PMD warnings (#342)

Author: newtork

.pipeline/config.yml

@@ -29,5 +29,5 @@ stages:
       low: '0'
     pmd:
       high: '0'
-      normal: '6'
-      low: '2'
+      normal: '1'
+      low: '0'

cloudplatform/cloudplatform-connectivity/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/UriPathMerger.java

@@ -94,15 +94,10 @@ public URI merge( @Nonnull final URI primaryUri, @Nullable final URI secondaryUr
     private void assertSecondaryHostMatchesPrimaryHost( @Nonnull final URI primaryUri, @Nonnull final URI secondaryUri )
         throws DestinationPathsNotMergeableException
     {
-        if( secondaryUri.getRawAuthority() != null ) {
-            if( !primaryUri.getRawAuthority().equals(secondaryUri.getRawAuthority()) ) {
-                throw new DestinationPathsNotMergeableException(
-                    String
-                        .format(
-                            "URIs defined in destination '%s' and supplied by application code '%s' differ.",
-                            primaryUri,
-                            secondaryUri));
-            }
+        if( secondaryUri.getRawAuthority() != null
+            && !primaryUri.getRawAuthority().equals(secondaryUri.getRawAuthority()) ) {
+            final String msg = "URIs defined in destination '%s' and supplied by application code '%s' differ.";
+            throw new DestinationPathsNotMergeableException(String.format(msg, primaryUri, secondaryUri));
         }
     }
 

cloudplatform/cloudplatform-core/src/main/java/com/sap/cloud/sdk/cloudplatform/thread/ThreadContextExecutor.java

@@ -274,6 +274,7 @@ public void execute( @Nonnull final Executable executable )
     }
 
     @Nullable
+    @SuppressWarnings( "PMD.SignatureDeclareThrowsException" ) // callable.call() throws Exception. We're not catching it here.
     private <T> T call( @Nonnull final Callable<T> callable )
         throws Exception
     {

cloudplatform/connectivity-destination-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationKeyStoreExtractor.java

@@ -46,6 +46,7 @@
 
 @Slf4j
 @RequiredArgsConstructor
+@SuppressWarnings( "PMD.TooManyStaticImports" )
 class DestinationKeyStoreExtractor
 {
     // See the supported key store file extensions:

datamodel/datamodel-metadata-generator/src/main/java/com/sap/cloud/sdk/datamodel/metadata/generator/DefaultMavenRepositoryAccessor.java

@@ -87,8 +87,7 @@ private String obtainLatestVersionViaHttp( final MavenCoordinate mavenCoordinate
                     + ".");
         }
         final String latestVersion;
-        try {
-            final InputStream stream = response.getEntity().getContent();
+        try( InputStream stream = response.getEntity().getContent() ) {
             final JsonNode tree = new XmlMapper().readTree(stream);
             latestVersion = tree.path("versioning").path("latest").asText();
         }

datamodel/odata/odata-generator/src/main/java/com/sap/cloud/sdk/datamodel/odata/generator/NamespaceClassGenerator.java

@@ -60,6 +60,7 @@
 /**
  * For internal use only.
  */
+@SuppressWarnings( "PMD.TooManyStaticImports" )
 class NamespaceClassGenerator
 {
     private static final Logger logger = MessageCollector.getLogger(NamespaceClassGenerator.class);

s4hana/s4hana-core/src/main/java/com/sap/cloud/sdk/s4hana/serialization/DecimalBasedErpType.java

@@ -126,6 +126,7 @@ private static BigDecimal fromErpToJavaDecimal( @Nullable String str )
         return new BigDecimal(str);
     }
 
+    @SuppressWarnings( "PMD.UselessParentheses" )
     private String toErpString()
     {
         if( value == null ) {

s4hana/s4hana-core/src/main/java/com/sap/cloud/sdk/s4hana/serialization/IntegerBasedErpType.java

@@ -185,6 +185,7 @@ public String toString()
         return toErpString();
     }
 
+    @SuppressWarnings( "PMD.UselessParentheses" )
     private String toErpString()
     {
         if( value == null ) {