chore: Switch error logging to throwing an exception for OnPrem conne… (#364)

Co-authored-by: Charles Dubois <[email protected]>
Co-authored-by: I538344 <[email protected]>

Author: MatKuhr

cloudplatform/cloudplatform-connectivity/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultHttpDestination.java

@@ -1004,15 +1004,7 @@ public DefaultHttpDestination build()
                     return proxyHandler.handle(this);
                 }
                 catch( final Exception e ) {
-                    final String msg =
-                        """
-                            Unable to resolve proxy configuration for destination. \
-                            This destination cannot be used for anything other than reading its properties. \
-                            This is unexpected and will be changed to fail instead in a future version of Cloud SDK. \
-                            Please analyze the attached stack trace and resolve the issue. \
-                            In case only the properties of a destination should be accessed, without performing authorization flows, please use the 'getDestinationProperties'  method on 'DestinationService' instead.\
-                            """;
-                    log.error(msg, e);
+                    throw new DestinationAccessException("Unable to resolve proxy configuration for destination", e);
                 }
             }
             return buildInternal();

cloudplatform/cloudplatform-connectivity/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultHttpDestinationTest.java

@@ -530,7 +530,6 @@ void testProxyConfigurationOverwritesExistingProperties()
                 .property(DestinationProperty.PROXY_HOST, "initial.host")
                 .property(DestinationProperty.PROXY_PORT, 4321)
                 .property(DestinationProperty.PROXY_AUTH, "Bearer initial-token")
-                .property(DestinationProperty.PROXY_TYPE, ProxyType.ON_PREMISE)
                 .build();
 
         final ProxyConfiguration proxyConfiguration =
@@ -549,7 +548,6 @@ void testProxyConfigurationOverwritesExistingProperties()
         assertThat(destination.get(DestinationProperty.PROXY_URI))
             .containsExactly(URI.create("http://overwritten.uri:5678"));
         assertThat(destination.get(DestinationProperty.PROXY_AUTH)).containsExactly("Bearer overwritten-token");
-        assertThat(destination.get(DestinationProperty.PROXY_TYPE)).containsExactly(ProxyType.ON_PREMISE);
         // "fallback" properties ARE NOT overwritten - this is done for compatibility with Cloud SDK v4 behavior
         assertThat(destination.get(DestinationProperty.PROXY_HOST)).containsExactly("initial.host");
         assertThat(destination.get(DestinationProperty.PROXY_PORT)).containsExactly(4321);

cloudplatform/cloudplatform-connectivity/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/EnvVarDestinationLoaderTest.java

@@ -196,7 +196,7 @@ void testProxyTypeUncommonSpelling()
               {
                 "type": "HTTP",
                 "name": "%s",
-                "proxyType": "onpremise",
+                "proxyType": "Internet",
                 "description": "This destination rocks!",
                 "authentication": "BasicAuthentication"
                 "URL": "https://URL",
@@ -218,7 +218,7 @@ void testProxyTypeUncommonSpelling()
         final HttpDestination httpDestination = destination.asHttp();
 
         final Option<ProxyType> proxyType = httpDestination.getProxyType();
-        assertThat(proxyType.get()).isEqualTo(ProxyType.ON_PREMISE);
+        assertThat(proxyType.get()).isEqualTo(ProxyType.INTERNET);
     }
 
     @Test
@@ -230,7 +230,7 @@ void testAdditionalProperty()
               {
                 "type": "HTTP",
                 "name": "%s",
-                "proxyType": "onpremise",
+                "proxyType": "Internet",
                 "description": "This destination rocks!",
                 "authentication": "BasicAuthentication"
                 "URL": "https://URL",
@@ -312,7 +312,7 @@ void testFallbackPropertyKeys()
               {
                 "type": "HTTP",
                 "name": "%s",
-                "proxyType": "onpremise",
+                "proxyType": "Internet",
                 "description": "This destination rocks!",
                 "URL": "https://URL",
                 "username": "USER",

cloudplatform/connectivity-oauth/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/OAuth2ServiceBindingDestinationLoaderTest.java

@@ -352,7 +352,7 @@ void testProxiedDestination()
     {
         final URI proxyUrl = URI.create("http://proxyUrl:1234");
         final DefaultHttpDestination baseDestination =
-            DefaultHttpDestination.builder(baseUrl).proxyType(ProxyType.ON_PREMISE).build();
+            DefaultHttpDestination.builder(baseUrl).proxyType(ProxyType.ON_PREMISE).buildInternal();
 
         final DestinationHeaderProvider headerProviderMock = mock(DestinationHeaderProvider.class);
         when(headerProviderMock.getHeaders(any())).thenReturn(Collections.emptyList());
@@ -460,7 +460,7 @@ void testSkipProxyTokenRetrieval()
     {
         final URI proxyUrl = URI.create("http://proxyUrl:1234");
         final DefaultHttpDestination baseDestination =
-            DefaultHttpDestination.builder(baseUrl).proxyType(ProxyType.ON_PREMISE).build();
+            DefaultHttpDestination.builder(baseUrl).proxyType(ProxyType.ON_PREMISE).buildInternal();
         final ServiceBindingDestinationOptions options =
             ServiceBindingDestinationOptions
                 .forService(EMPTY_BINDING)

release_notes.md

@@ -13,6 +13,8 @@
   - CAP `com.sap.cds` 2.9.3
   - SAP Java Buildpack `com.sap.cloud.sjb` 2.10.0
 - Using IAS requires XSUAA version to be minimum `3.4.0`.
+- Change the `DefaultHttpDestination.Builder` to throw an exception when the proxy configuration can not be determined for on-premise destinations.
+  Previously, only an error was logged to give a grace period for analyzing and fixing the underlying issue.
 
 ### ✨ New Functionality