Skip to content

Commit 5b649d1

Browse files
committed
feat: add logging for data retrieval failures
1 parent 106511b commit 5b649d1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/main/java/io/neonbee/data/DataVerticle.java

+8-2
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,11 @@ public static <U> Future<U> requestData(Vertx vertx, DataRequest request, DataCo
111111
DataSource<?> dataSource = request.getDataSource();
112112

113113
if (dataSource != null) {
114-
return dataSource.retrieveData(request.getQuery(), context).map(FunctionalHelper::uncheckedMapper);
114+
return dataSource
115+
.retrieveData(request.getQuery(), context)
116+
.onFailure(throwable -> LOGGER.correlateWith(context)
117+
.error("Failed to retrieve data from data source from {}", request.getQualifiedName()))
118+
.map(FunctionalHelper::uncheckedMapper);
115119
}
116120

117121
DataSink<?> dataSink = request.getDataSink();
@@ -603,7 +607,9 @@ public Future<T> execute(DataQuery query, DataContext context) {
603607
.map(entry -> Map.entry(entry.getKey(), entry.getValue().responseData()))
604608
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
605609
context.setReceivedData(receivedData);
606-
Future<T> future = retrieveData(query, new DataMap(requestResults), context);
610+
Future<T> future = retrieveData(query, new DataMap(requestResults), context)
611+
.onFailure(throwable -> LOGGER.correlateWith(context)
612+
.error("Failed to retrieve data from data source from {}", getQualifiedName()));
607613
reportRetrieveDataMetrics(tags, future);
608614
return future;
609615
} catch (Exception e) {

0 commit comments

Comments
 (0)