Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - ABAP inquirer is not handling the default package name read from ATO settings #2991

Open
3 tasks
longieirl opened this issue Mar 4, 2025 · 0 comments
Open
3 tasks
Assignees
Labels
abap-deploy-config-inquirer bug Something isn't working

Comments

@longieirl
Copy link
Contributor

longieirl commented Mar 4, 2025

Description

When consuming a destination defined using tenantType of CUSTOMER and the following ATO settings;

<?xml version="1.0" encoding="utf-8"?>
<ato:settings developmentPackage="TEST_YY1_DEFAULT" developmentPrefix="YY1_" isConfigured="true" isExtensibilityDevelopmentSystem="true" isManagedExtensibilityActive="false" isNotificationAllowed="true" isPrefixNamespace="false" isTransportRequestRequired="false" operationsType="C" sandboxPackage="TEST_YY1_DEFAULT" sandboxPrefix="YY9_" tenantRole="07" tenantType="CUSTOMER" transportationMode="COL" xmlns:ato="http://www.sap.com/adt/ato"/>

The ui5-deploy.yaml configuration is generated using;

        app:
          name: YY1_BPTEST0303
          package: $TMP
          transport: ''

The package property should be updated with TEST_YY1_DEFAULT as read from the ATO settings.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Generate a HTML5 using a destination configured with tenantType of customer and
  2. Add deployment configuration

Expected results

ui5-deploy.yaml is generated with a package of TEST_YY1_DEFAULT which is the value read from the ATO settings developmentPackage.

Actual results

package is defaulting to $TMP

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@longieirl longieirl self-assigned this Mar 4, 2025
@longieirl longieirl added the bug Something isn't working label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abap-deploy-config-inquirer bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant