Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][ui5-input]: Clear icon should be decorative #10100

Closed
1 task done
zhangliangyi opened this issue Oct 29, 2024 · 3 comments
Closed
1 task done

[SF][ui5-input]: Clear icon should be decorative #10100

zhangliangyi opened this issue Oct 29, 2024 · 3 comments
Assignees
Labels
bug This issue is a bug in the code Medium Prio SF_ACC TOPIC RL

Comments

@zhangliangyi
Copy link

Bug Description

Since the clear icon in ui5-input is not accessible to keyboard users, it should be set as decorative mode so that the icon would be invisible to screen reader.

Affected Component

ui5-input

Expected Behaviour

Set the mode of icon as Decorative.

<ui5-icon part="clear-icon" tabindex="-1" class="ui5-input-clear-icon" name="decline" accessible-name="{{clearIconAccessibleName}}"></ui5-icon>

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.3.0

Browser

Edge

Operating System

No response

Additional Context

No response

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@zhangliangyi zhangliangyi added the bug This issue is a bug in the code label Oct 29, 2024
@dimovpetar dimovpetar self-assigned this Oct 29, 2024
@dimovpetar
Copy link
Contributor

Hello @ui5-webcomponents-topic-rl,

Please check out if this accessibility concern is valid.
In OpenUI5, the clear icon behaves the same way,

Best regards,
Petar

@ndeshev
Copy link
Contributor

ndeshev commented Nov 1, 2024

Hello @zhangliangyi I will further discuss this proposal with our accessibility experts, because the clear icon can be clicked, so it has some interactivity and it is not purely decorative.

@ndeshev
Copy link
Contributor

ndeshev commented Nov 4, 2024

Hello again, I've talked with our accessibility experts and there are ongoing discussions on the topic of this issue. We have a backlog item related to it but there is no final conclusion yet. There is also a related GitHub issue on the matter - #9870 which you can follow for solution of the topic.

@ndeshev ndeshev closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SF_ACC TOPIC RL
Projects
Status: Completed
Development

No branches or pull requests

3 participants