Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-menu-item]: Incorrect spelling of ui5-menu-rp-sub-menu class #11043

Open
dimovpetar opened this issue Mar 10, 2025 · 0 comments
Open

[ui5-menu-item]: Incorrect spelling of ui5-menu-rp-sub-menu class #11043

dimovpetar opened this issue Mar 10, 2025 · 0 comments
Labels
bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@dimovpetar
Copy link
Contributor

In MenuItemTemplate.tsx, ui5-menu-rp-sub-menu class is written with leading dot, which is incorrect. As a results, some CSS selectors depending on this class are ineffective.

class="ui5-menu-rp .ui5-menu-rp-sub-menu"

After the fix, test if the following styles, located in MenuItem.css, are needed:

.ui5-menu-rp.ui5-menu-rp-sub-menu {
	margin-top: 0.25rem;
	margin-inline: var(--_ui5_menu_submenu_margin_offset);
}

.ui5-menu-rp.ui5-menu-rp-sub-menu[actual-placement="Start"] {
	margin-top: 0.25rem;
	margin-inline: var(--_ui5_menu_submenu_placement_type_left_margin_offset);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Status: New Issues
Development

No branches or pull requests

1 participant