Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel]: Bad spacing between arrow and title #11062

Open
1 task done
mhchem opened this issue Mar 11, 2025 · 1 comment
Open
1 task done

[Panel]: Bad spacing between arrow and title #11062

mhchem opened this issue Mar 11, 2025 · 1 comment
Labels
bug This issue is a bug in the code Low Prio TOPIC RL

Comments

@mhchem
Copy link

mhchem commented Mar 11, 2025

Bug Description

Looking at https://sap.github.io/ui5-webcomponents/components/Panel/, I see that the title begins with a 40px distance to the left.

.ui5-panel-header-title {
width: calc(100% - var(--_ui5-v2-8-0_panel_button_root_width));
with the variable being 2.5rem;

However, this is not according to the spec, which says B.1 = width:2.75rem (44px).

Affected Component

Panel

Expected Behaviour

2.75rem distance

Declaration

  • I’m not disclosing any internal or sensitive information.
@PetyaMarkovaBogdanova
Copy link
Contributor

Dear colleagues from @SAP/ui5-webcomponents-topic-rl ,
since this change : https://github.com/SAP/ui5-webcomponents/pull/7906/files#diff-804144e6978846de00695340bf85e6f8d23bdd59ffefd7a66e303c7b62039748
the var --_ui5_panel_button_root_width is taking its value from the base Panel-parameters, which concludes to 2.5rem, instead of 2.75rem as it is in the spec for sap_horizon theme, after the override for this theme is removed.
I hope that helps, can you, please, take a look?
Best regards,
Petya Markova.
UI5 Web Components Dispatcher

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova removed their assignment Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Low Prio TOPIC RL
Projects
Status: New Issues
Development

No branches or pull requests

2 participants