Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MessageStrip]: Close button tooltip message is not according to design and no accessibleName is present. #9874

Open
1 task done
pankajpandey01 opened this issue Sep 13, 2024 · 4 comments

Comments

@pankajpandey01
Copy link

Describe the bug

Close button tooltip message is not according to design.
Same tooltip is shown for Design - "Information", "Positive", "Negative", "Warning
Tooltip: Information Bar Close

There is no accessibleName

Isolated Example

No response

Reproduction steps

  1. Go to https://sap.github.io/ui5-webcomponents-react/v1/?path=/docs/data-display-messagestrip--docs
  2. See close button tooltip of MessageStrip

Expected Behaviour

Tooltip message should be according to design.
accessibleName should be present. (It is good to have same accessibleName as tooltip otherwise Screen Reader will read both tooltip and accessibleName which usually will have same meaning in this case)

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.3

UI5 Web Components Version

1.24.7

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@pankajpandey01 pankajpandey01 added the bug This issue is a bug in the code label Sep 13, 2024
@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Sep 15, 2024
@IlianaB IlianaB added feature request TOPIC RL SAP SF SF_ACC and removed bug This issue is a bug in the code labels Sep 16, 2024
@IlianaB
Copy link
Member

IlianaB commented Sep 16, 2024

Hello @SAP/ui5-webcomponents-topic-rl , this inquiry looks more like a feature request. Please, consider if accessibleName is required here and/or the tooltip message should be different according to the "design" of the MessageStrip - "Information", "Positive", "Negative", "Warning" (currently, it is "Information Bar Close" for all designs).

Regards,
Iliana

@elenastoyanovaa elenastoyanovaa self-assigned this Oct 10, 2024
@elenastoyanovaa
Copy link
Contributor

Hello,

We will enrich the tooltip of the close button according to the spec, but in the specification there is no accessibleName.
As these are to different requests I would like to ask you to follow the InnerSource process for design change and request the accessibleName separately. Please keep in mind that a use case should be provided.

In this issue we will process the enrichment of the tooltip - including the design in the tooltip value. We need to double check with the designers if we should add Positive or Success and etc, for the other types of design.

Kind Regards,
Elena

@hristop
Copy link
Contributor

hristop commented Oct 16, 2024

P1 BLI was created: FIORITECHP1-31872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Approved
Development

No branches or pull requests

5 participants