Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar]: decorative property should be supported #9875

Open
1 task done
pankajpandey01 opened this issue Sep 13, 2024 · 6 comments
Open
1 task done

[Avatar]: decorative property should be supported #9875

pankajpandey01 opened this issue Sep 13, 2024 · 6 comments

Comments

@pankajpandey01
Copy link

pankajpandey01 commented Sep 13, 2024

Is your feature request related to a problem?

Yes. In some cases Avatar is just used for decorative purpose and should be ignored by accessibility tools.
For example: Avatar user name is shown in text beside the avatar, In this case Screen reader will read user name from text and also from Avatar accessibleName as shown below
Screenshot 2024-09-13 at 4 42 33 PM

Describe the solution you'd like

Provide decorative property like : https://ui5.sap.com//#/api/sap.m.Avatar%23controlProperties

Describe alternatives you've considered

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Sep 15, 2024
@IlianaB
Copy link
Member

IlianaB commented Sep 16, 2024

Hello @SAP/ui5-webcomponents-topic-p, take a look of this feature request.

Regards,
Iliana

@IlianaB IlianaB added the SAP SF label Sep 16, 2024
@dobrinyonkov
Copy link
Contributor

Hi @pankajpandey01,

Thanks for your feature request!
As per the new design requirements, this item should go through the inner source process. Could you please create a Jira item for Central Design and include the E1 reference number here?
Let me know if you have questions!

Thanks and Best Regards,
Dobrin

@pankajpandey01
Copy link
Author

pankajpandey01 commented Sep 26, 2024

Hi @dobrinyonkov ,
I don't see any design change in this feature request. Its a a11y feature which will not affect design and it is already supported in UI5 https://ui5.sap.com//#/api/sap.m.Avatar%23controlProperties. So please let me know why central design ticket is needed?

@dobrinyonkov
Copy link
Contributor

Hi @pankajpandey01,

While the UI5 Avatar control supports this property, it is not currently part of the a11y specification. As such, the specification will need to be updated. Since the a11y specification is now managed by the design team, any updates or changes must go through their evaluation process.

Regards,
Dobrin

@pankajpandey01
Copy link
Author

Hi @dobrinyonkov
created central design ticket : FIORITECHE1-8671

Thanks,
Pankaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants