Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider is missing icon #9887

Closed
1 task done
brandon-sap opened this issue Sep 17, 2024 · 1 comment · Fixed by #9924
Closed
1 task done

Slider is missing icon #9887

brandon-sap opened this issue Sep 17, 2024 · 1 comment · Fixed by #9924
Assignees
Labels
bug This issue is a bug in the code Low Prio TOPIC RL

Comments

@brandon-sap
Copy link
Member

Bug Description

The slider component is showing a blank icon. There's a warning in the console:

Icon.ts:268 Icon name property is required
<ui5-icon mode="Decorative" "direction-arrows"="" part="icon-slider" slider-icon="" ui5-icon="" design="Default" desktop="">

This happens in the documentation for the Slider component, too. Here's a link to the documentation that shows the bug:
https://sap.github.io/ui5-webcomponents/components/Slider/#basic-sample

Looking at the HTML for the icon (conveniently provided in the console warning) shows that maybe the name attribute got a little messed up, since there's an attribute "direction-arrows", when I think it should be name="direction-arrows".

Affected Component

Slider

Expected Behaviour

No warning in the console, the icon should show up on the handle like it does on the RangeSlider component.

Isolated Example

https://sap.github.io/ui5-webcomponents/components/Slider/#basic-sample

Steps to Reproduce

  1. Open the documentation link
  2. Observe a blank handle in the basic slider example

Log Output, Stack Trace or Screenshots

Icon.ts:268 Icon name property is required
<ui5-icon mode="Decorative" "direction-arrows"="" part="icon-slider" slider-icon="" ui5-icon="" design="Default" desktop="">

{58D0FA7B-0B54-4086-9D34-7EE9C5F2B4DA}

{53D4A62F-CF6C-490A-A5CD-E2D743DBA780}

Priority

Low

UI5 Web Components Version

2.2.0

Browser

Chrome

Operating System

Windows 11

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@brandon-sap brandon-sap added the bug This issue is a bug in the code label Sep 17, 2024
@nnaydenow
Copy link
Contributor

Hello @sap/webcomponents-topic-rl,

Could you please check this issue?

As I saw the name attribute was removed with https://github.com/SAP/ui5-webcomponents/pull/9649/files#diff-99805288e28007558cae7e7369f03686d0c37f7d196b3b6115c03771c541cbdcR35 and only its value was left.

Regards,
Nayden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Low Prio TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants