Skip to content

Commit cba959d

Browse files
committed
Fix the compatible with SDWebImage 5.7, which have a query cache type
1 parent 5993bb4 commit cba959d

File tree

5 files changed

+29
-22
lines changed

5 files changed

+29
-22
lines changed

Cartfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
github "SDWebImage/SDWebImage" ~> 5.6
1+
github "SDWebImage/SDWebImage" ~> 5.7
22
github "ibireme/YYCache" ~> 1.0
33
github "ibireme/YYImage" ~> 1.0

Cartfile.resolved

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
github "SDWebImage/SDWebImage" "5.6.0"
1+
github "SDWebImage/SDWebImage" "5.7.0"
22
github "ibireme/YYCache" "1.0.4"
33
github "ibireme/YYImage" "1.0.4"

Example/Podfile.lock

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
PODS:
22
- Expecta (1.0.6)
3-
- SDWebImage/Core (5.6.0)
4-
- SDWebImageYYPlugin (0.3.0):
5-
- SDWebImage/Core (~> 5.4)
6-
- SDWebImageYYPlugin/YYCache (= 0.3.0)
7-
- SDWebImageYYPlugin/YYImage (= 0.3.0)
8-
- SDWebImageYYPlugin/YYCache (0.3.0):
9-
- SDWebImage/Core (~> 5.4)
3+
- SDWebImage/Core (5.7.0)
4+
- SDWebImageYYPlugin (0.4.0):
5+
- SDWebImage/Core (~> 5.7)
6+
- SDWebImageYYPlugin/YYCache (= 0.4.0)
7+
- SDWebImageYYPlugin/YYImage (= 0.4.0)
8+
- SDWebImageYYPlugin/YYCache (0.4.0):
9+
- SDWebImage/Core (~> 5.7)
1010
- YYCache
11-
- SDWebImageYYPlugin/YYImage (0.3.0):
12-
- SDWebImage/Core (~> 5.4)
11+
- SDWebImageYYPlugin/YYImage (0.4.0):
12+
- SDWebImage/Core (~> 5.7)
1313
- YYImage/Core
1414
- YYCache (1.0.4)
1515
- YYImage/Core (1.0.4)
@@ -34,8 +34,8 @@ EXTERNAL SOURCES:
3434

3535
SPEC CHECKSUMS:
3636
Expecta: 3b6bd90a64b9a1dcb0b70aa0e10a7f8f631667d5
37-
SDWebImage: 21b19f56b4226cdfe3aefe4e6848dc43ed129a86
38-
SDWebImageYYPlugin: f6c1af162fb075efe5918d8caedee1f3d17c197e
37+
SDWebImage: a99471f452bdfa0ca52ddf5b1adf2b61cab1d1eb
38+
SDWebImageYYPlugin: daa0b74897dd769fa63092e60cde49f3719048bc
3939
YYCache: 8105b6638f5e849296c71f331ff83891a4942952
4040
YYImage: 1e1b62a9997399593e4b9c4ecfbbabbf1d3f3b54
4141

SDWebImageYYPlugin.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ TODO: Add long description of the pod here.
3131
s.source_files = 'SDWebImageYYPlugin/Module/SDWebImageYYPlugin.h'
3232
s.module_map = 'SDWebImageYYPlugin/Module/SDWebImageYYPlugin.modulemap'
3333

34-
s.dependency 'SDWebImage/Core', '~> 5.6'
34+
s.dependency 'SDWebImage/Core', '~> 5.7'
3535

3636
s.subspec 'YYCache' do |ss|
3737
ss.dependency 'YYCache'

SDWebImageYYPlugin/Classes/YYCache/YYCacheBridge/YYCache+SDAdditions.m

+15-8
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,29 @@
4141
@implementation YYCache (SDAdditions)
4242

4343
- (id<SDWebImageOperation>)queryImageForKey:(NSString *)key options:(SDWebImageOptions)options context:(SDWebImageContext *)context completion:(SDImageCacheQueryCompletionBlock)doneBlock {
44+
return [self queryImageForKey:key options:options context:context cacheType:SDImageCacheTypeAll completion:doneBlock];
45+
}
46+
47+
- (id<SDWebImageOperation>)queryImageForKey:(NSString *)key options:(SDWebImageOptions)options context:(SDWebImageContext *)context cacheType:(SDImageCacheType)queryCacheType completion:(SDImageCacheQueryCompletionBlock)doneBlock {
4448
if (!key) {
4549
if (doneBlock) {
4650
doneBlock(nil, nil, SDImageCacheTypeNone);
4751
}
4852
return nil;
4953
}
50-
51-
id<SDImageTransformer> transformer = context[SDWebImageContextImageTransformer];
52-
if (transformer) {
53-
// grab the transformed disk image if transformer provided
54-
NSString *transformerKey = [transformer transformerKey];
55-
key = SDTransformedKeyForKey(key, transformerKey);
54+
// Invalid cache type
55+
if (queryCacheType == SDImageCacheTypeNone) {
56+
if (doneBlock) {
57+
doneBlock(nil, nil, SDImageCacheTypeNone);
58+
}
59+
return nil;
5660
}
5761

5862
// First check the in-memory cache...
59-
UIImage *image = [self.memoryCache objectForKey:key];
63+
UIImage *image;
64+
if (queryCacheType != SDImageCacheTypeDisk) {
65+
image = [self.memoryCache objectForKey:key];
66+
}
6067

6168
if (image) {
6269
if (options & SDImageCacheDecodeFirstFrameOnly) {
@@ -79,7 +86,7 @@ @implementation YYCache (SDAdditions)
7986
}
8087
}
8188

82-
BOOL shouldQueryMemoryOnly = (image && !(options & SDImageCacheQueryMemoryData));
89+
BOOL shouldQueryMemoryOnly = (queryCacheType == SDImageCacheTypeMemory) || (image && !(options & SDImageCacheQueryMemoryData));
8390
if (shouldQueryMemoryOnly) {
8491
if (doneBlock) {
8592
doneBlock(image, nil, SDImageCacheTypeMemory);

0 commit comments

Comments
 (0)