test: short position opened and funded from short token (USDC) pool

[abayomicornelius]

Goal

Verify the complete lifecycle of a short position where the collateral and PnL are denominated in the short token (USDC).

Scenario

1. LP deposits 20,000 USDC into the ETH/USD market short side
2. Trader opens 5 ETH short at 2000 USD with 1000 USDC collateral
3. Price moves to 1800 USD — position has 1000 USD unrealised profit
4. Trader closes the position
5. Trader receives 1000 USDC collateral + 1000 USDC PnL = 2000 USDC

Assertions

• USDC pool decreases by exactly 1000 (the PnL paid out)
• Short OI decreases to 0
• Position removed from storage
• No ETH pool balance changes (short uses only USDC)

Acceptance Criteria

• Test uses the actual execute_order flow, not mocked PnL
• Test covers the losing-short case too: price rises, trader loses collateral, pool gains
• File: tests/short_position_lifecycle.rs

[Promzy204-bad]

@Promzy204-bad has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Promzy204-bad to this issue.