Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a fast version of comp::Map #22

Open
SOF3 opened this issue Nov 22, 2022 · 0 comments
Open

Implement a fast version of comp::Map #22

SOF3 opened this issue Nov 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@SOF3
Copy link
Owner

SOF3 commented Nov 22, 2022

Currently comp::Map uses a BTreeMap, where remove_single is a slow operation. Checking for duplicates is probably unnecessary anyway, and isotopes could have been split to a separate field instead of mixing with simple components.
@SOF3 SOF3 added the enhancement New feature or request label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SOF3