Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate alerts for same certificates or renewals #26

Open
oskar456 opened this issue Apr 9, 2018 · 5 comments
Open

Avoid duplicate alerts for same certificates or renewals #26

oskar456 opened this issue Apr 9, 2018 · 5 comments
Labels
Milestone

Comments

@oskar456
Copy link

oskar456 commented Apr 9, 2018

To avoid unnecessary noise, it would be nice if there were options:

  • not to report a certificate that has been already reported in some different log
  • not to report a certificate sharing public key with an already reported certificate (targeted mostly for renewals without rekeying)

Thanks for this great peace of software!

@AGWA
Copy link
Member

AGWA commented Apr 9, 2018

Cert Spotter already suppresses notifications for duplicate certificates, as long as you don't specify the -no_save option.

The second suggestion is a good one.

@AGWA
Copy link
Member

AGWA commented Apr 9, 2018

One caveat: Cert Spotter considers the pre-certificate and final certificate to be different, so you may get up to two alerts for a single issuance. It would be good to deduplicate those alerts too.

@AGWA AGWA added the feature label Sep 22, 2023
@AGWA AGWA changed the title Feature request: avoid duplicate alerts for same certificates or renewals Avoid duplicate alerts for same certificates or renewals Sep 22, 2023
@AGWA AGWA added this to the Reduce noise milestone Oct 21, 2023
@certrik
Copy link

certrik commented May 13, 2024

Is Cert Spotter already suppresses notifications for duplicate certificates, as long as you don't specify the -no_save option. documented anywhere? Because I ran in to this and didn't find any docu. Maybe it is just hidden well.

@AGWA
Copy link
Member

AGWA commented May 13, 2024

@certrik what information would have been helpful? That turning on -no_save causes duplicate notifications to be sent?

@certrik
Copy link

certrik commented May 14, 2024

Yes. That is an interesting information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants