realmd: Adding new methods and rearrange code

Adding new methods:
 1. permit
 2. deny
 3. renew

Adding helper executer function to remove redundant codeline.

Author: shridhargadekar

sssd_test_framework/utils/realmd.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from pytest_mh import MultihostHost, MultihostUtility
+from pytest_mh.cli import CLIBuilder, CLIBuilderArgs
 from pytest_mh.conn import ProcessResult
 
 __all__ = [
@@ -19,11 +20,69 @@ class RealmUtils(MultihostUtility[MultihostHost]):
 
         @pytest.mark.topology(KnownTopology.AD)
         def test_realm_discover(client: Client, provider: ADProvider):
-            r = client.realm.discover(["--use-ldaps"])
+            r = client.realm.discover(provider.host.domain, args=["--use-ldaps"])
             assert provider.host.domain in r.stdout, "realm failed to discover domain info!"
 
     """
 
+    def __init__(self, host: MultihostHost) -> None:
+        """
+        Initialize the RealmUtils.
+
+        :param host: The multihost host instance.
+        :type host: MultihostHost
+        """
+        super().__init__(host)
+        self.cli: CLIBuilder = self.host.cli
+        """Command line builder."""
+
+    def _exec_realm(
+        self,
+        subcommand: str,
+        *,
+        password: str | None = None,
+        user: str | None = None,
+        domain: str | None = None,
+        args: list[str] | None = None,
+        krb: bool = False,
+    ) -> ProcessResult:
+        """
+        Execute realm commands.
+
+        :param subcommand: Subcommand (e.g., "join", "leave").
+        :type subcommand: str
+        :param password: Password, defaults to None.
+        :type password: str
+        :param user: User, defaults to None.
+        :type user: str
+        :param domain: domain.
+        :type domain: str, optional
+        :param args: Additional arguments.
+        :type args: list[str] | None, optional
+        :param krb: Use Kerberos.
+        :type krb: bool
+        :return: ProcessResult
+        :rtype: ProcessResult
+        """
+        if args is None:
+            args = []
+
+        # Base command
+        command = ["realm", subcommand, "--verbose", *args]
+
+        if krb:
+            self.host.conn.exec(["kinit", f"{user}"], input=password)
+            if domain:
+                command.append(domain)
+            return self.host.conn.exec(command)
+        else:
+            # execute with password as input
+            if user:
+                command.extend(["-U", user])
+            if domain:
+                command.append(domain)
+            return self.host.conn.exec(command, input=password)
+
     def discover(self, domain: str | None = None, *, args: list[str] | None = None) -> ProcessResult:
         """
         Discover a realm and it's capabilities.
@@ -32,6 +91,8 @@ def discover(self, domain: str | None = None, *, args: list[str] | None = None)
         :type domain: str, optional
         :param args: Additional arguments, defaults to None
         :type args: list[str] | None, optional
+        :return: Result of called command.
+        :rtype: ProcessResult
         """
         if args is None:
             args = []
@@ -52,27 +113,27 @@ def leave(
         """
         Deconfigure and remove a client from realm.
 
-        :param domain: domain to leave.
-        :type domain: str,
+        :param domain: domain.
+        :type domain: str
         :param args: Additional arguments, defaults to None.
         :type args: list[str] | None, optional
         :param password: Password to run the operation.
         :type password: str
         :param user: Authenticating user.
         :type user: str
-        :param krb: Enable kerberos authentication, defaults to False.
+        :param krb: kerberos authentication, defaults to False.
         :type krb: bool
+        :return: Result of called command.
+        :rtype: ProcessResult
         """
-        if args is None:
-            args = []
-
-        if krb:
-            self.host.conn.exec(["kinit", user], input=password)
-            result = self.host.conn.exec(["realm", "leave", "--verbose", *args, domain])
-        else:
-            result = self.host.conn.exec(["realm", "leave", "--verbose", *args, "-U", user, domain], input=password)
-
-        return result
+        return self._exec_realm(
+            "leave",
+            domain=domain or None,  # Pass None to helper if empty string
+            args=args,
+            password=password,
+            user=user,
+            krb=krb,
+        )
 
     def join(
         self,
@@ -86,34 +147,90 @@ def join(
         """
         Join and configure a client to realm.
 
-        :param domain: Domain to join.
+        :param domain: Domain.
         :type domain: str
         :param args: Additional arguments, defaults to None
         :type args: list[str] | None, optional
-        :param password: Password to run the operation.
+        :param password: Password.
         :type password: str
         :param user: Authenticating user.
         :type user: str
-        :param krb: Enable kerberos authentication, defaults to False
+        :param krb: Kerberos authentication, defaults to False
         :type krb: bool
+        :return: Result of called command.
+        :rtype: ProcessResult
+        """
+        return self._exec_realm(
+            "join",
+            domain=domain,
+            args=args,
+            password=password,
+            user=user,
+            krb=krb,
+        )
+
+    def renew(
+        self,
+        domain,
+        *,
+        args: list[str] | None = None,
+    ) -> ProcessResult:
+        """
+        Renew host keytab.
+
+        :param domain: domain.
+        :type domain: str
+        :param args: Additional arguments, defaults to None
+        :type args: list[str] | None, optional
+        :return: Result of called command.
+        :rtype: ProcessResult
         """
         if args is None:
             args = []
 
-        if krb:
-            self.host.conn.exec(["kinit", user], input=password)
-            result = self.host.conn.exec(["realm", "join", "--verbose", *args, domain])
-        else:
-            result = self.host.conn.exec(["realm", "join", "--verbose", *args, "-U", user, domain], input=password)
+        command = ["realm", "renew", domain, "--verbose", *args]
+        return self.host.conn.exec(command)
+
+    def permit(self, user: str, *, withdraw: bool = False, args: list[str] | None = None) -> ProcessResult:
+        """
+        Permit users log in.
+
+        :param user: User to permit.
+        :type user: str
+        :param withdraw: Withdraw permission, defaults to False
+        :type withdraw: bool, optional
+        :param args: Additional arguments, defaults to None
+        :type args: list[str] | None, optional
+        :return: Result of called command.
+        :rtype: ProcessResult
+        """
+        cli_args: CLIBuilderArgs = {"withdraw": (self.cli.option.SWITCH, withdraw)}
+        if args is None:
+            args = []
 
-        return result
+        return self.host.conn.exec(["realm", "permit", *self.cli.args(cli_args), *args, user])
+
+    def deny(self, user: str, *, args: list[str] | None = None) -> ProcessResult:
+        """
+        Deny users log in.
+
+        :param user: User.
+        :type user: str
+        :param args: Additional arguments, defaults to None
+        :type args: list[str] | None, optional
+        :return: Result of called command.
+        :rtype: ProcessResult
+        """
+        return self.permit(user, withdraw=True, args=args)
 
     def list(self, *, args: list[str] | None = None) -> ProcessResult:
         """
         List discovered, and configured realms.
 
         :param args: Additional arguments, defaults to None
         :type args: list[str] | None, optional
+        :return: Result of called command.
+        :rtype: ProcessResult
         """
         if args is None:
             args = []