You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
vm-node writes the port to file that the VM is expected to use
vm-node waits indefinitely for crete-run to connect (also a separate issue)
vm-node is restarted manually
crete-run reads the old port file when the VM starts before vm-node has written a new one
Solution:
A fix should be simple. Just ensure the port file is removed before the VM image is started. This could be done in VMNodeFSM's ctor (or equivalent). A more robust solution is to follow the core guidelines R.1.
The present implementation is lacking sufficient resource (i.e., the port file) management:
Clearly, this is inadequate. If open_connection_wait() throws, or vm-node is terminated between these two invocations, fs::remove() is not invoked, thus causing the same problem.
The text was updated successfully, but these errors were encountered:
Scenario:
Solution:
A fix should be simple. Just ensure the port file is removed before the VM image is started. This could be done in VMNodeFSM's ctor (or equivalent). A more robust solution is to follow the core guidelines R.1.
The present implementation is lacking sufficient resource (i.e., the port file) management:
Clearly, this is inadequate. If open_connection_wait() throws, or vm-node is terminated between these two invocations, fs::remove() is not invoked, thus causing the same problem.
The text was updated successfully, but these errors were encountered: