bug: binary not downloading properly

[Ramilito]

Hi!

The binary isn't being downloaded immediately, I'm planning to take a look my self but for transparency I'm creating this ticket:

More context here: Ramilito/kubectl.nvim#592

Summary:

What should happen

Blink.download should download latest binary when you do a lazy.nvim update, is that not what you're seeing?

What is happening

It does download it, but not while doing the Lazy update. I need to update first with lazy, and then once I close and re-open the editor, the download of the binary happens.

[Saghen]

Hi! We could update when lazy.nvim does but if the plugin has been loaded already, then lazy.nvim update runs, the loaded lua files won't be updated until the editor is restarted anyway. And by extension, the updated shared library also won't be used until the editor restarts.

If you want to do this though, you could make a call to ensure_downloaded after the lazy.nvim update autocmd fires. blink.download leaves when to pull the binary up to the plugin author, but I'd be open to adding a ensure_downloaded(..., { trigger_on_update = true }) (or something along those lines) to have it listen to the autocmd.

Adding this may require a fix for Windows though, as shared libraries that are currently loaded, cannot be deleted. See: Saghen/blink.cmp#1794

[Ramilito]

I see, I had not thought about the lua code.
How about just adjusting the printed notification to include that this will be in affect on next restart?

[Saghen]

Which notification?

[Ramilito]

My bad, I thought that it was in the plugin since blink.cmp prints similar output but I see now that It's in the usage of the plugin:

  downloader.ensure_downloaded({
    -- omit this property to disable downloading
    -- i.e. https://github.com/Saghen/blink.delimiters/releases/download/v0.1.0/x86_64-unknown-linux-gnu.so
    download_url = function(version, system_triple, extension)
      return "https://github.com/ramilito/kubectl.nvim/releases/download/"
        .. version
        .. "/"
        .. system_triple
        .. extension
    end,
    on_download = function()
      vim.notify("[Kubectl.nvim] Downloading prebuilt binary...", vim.log.levels.INFO, { title = "kubectl.nvim" })
    end,

    root_dir = root_dir,
    output_dir = "/target/release",
    binary_name = "kubectl_client", -- excluding `lib` prefix
  }, callback)

I'll update my implementation and close this issue!

[Saghen]

Sounds good! I'll look into that other issue soon, been a bit absorbed by frizbee lately :D