Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application_history の排除 #62

Open
coord-e opened this issue Jul 28, 2018 · 1 comment
Open

application_history の排除 #62

coord-e opened this issue Jul 28, 2018 · 1 comment
Labels
enhancement New feature or request low priority This issue or pull request can be postponed

Comments

@coord-e
Copy link
Contributor

coord-e commented Jul 28, 2018

Step 1: 目的

  • /applicationsを使っているので、/statusapplicaiton_history を使うのをやめる

Step 2: 概要

  • なんだか少しapplication_historyの名残があるようなので、排除する

関連するコード:

https://github.com/Sakuten/frontend/search?q=application_history&unscoped_q=application_history

@coord-e coord-e added enhancement New feature or request low priority This issue or pull request can be postponed labels Jul 28, 2018
@Cj-bc
Copy link
Member

Cj-bc commented Aug 5, 2018

backendからの報告です。
backend#113のマージにより、/statusapplication_historyを返さない仕様になりました。
今後この値を取得しようとするとエラーが出る可能性があります。

尚、それに伴い/lotteries/{id}/draw及び/draw_allも各winnerのapplications_historyを返さなくなっています。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority This issue or pull request can be postponed
Projects
None yet
Development

No branches or pull requests

2 participants