Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable boolean options with default value true like --pull and --rebuild #127

Open
ChristopherHX opened this issue Dec 22, 2024 · 5 comments · May be fixed by #144
Open

Cannot disable boolean options with default value true like --pull and --rebuild #127

ChristopherHX opened this issue Dec 22, 2024 · 5 comments · May be fixed by #144
Labels
bug Something isn't working

Comments

@ChristopherHX
Copy link
Contributor

Github Local Actions Version

dev

Act Version

0.2.70

GitHub Repository Link

N/A

Workflow Content

N/A

Act Command Used

N/A

Act Command Output

N/A

Bug Description

Related to discussions in #117

Until nektos/act#2522 would be merged we cannot disable --pull and --rebuild using your GUI.

While at the moment I think this will not happen at all.

Usage is --pull=false to explicitly disable them and not using default true

getAllOptions() will have default value set to true for them.

I had to make a breaking change to the default docker images in 2023 and forcing everyone to update their image was easier than handling the possible bug reports of broken images.
Changing defaults is less breaking than renaming the options to contain negation in it's name.

Act Bug Report

N/A
@ChristopherHX ChristopherHX added the bug Something isn't working label Dec 22, 2024
@ChristopherHX
Copy link
Contributor Author

for options of type bool, having "true" or "false" as only selectable values in edit could help while =true can be omitted on the cli like today.

Alternatively passing options with default true if disabled via checkbox with value false and keep current behavior for normal options.

@aliuq
Copy link

aliuq commented Jan 10, 2025

Sometimes you will encounter the following error. Can we set pull to false to prevent forcePull=true?

Error response from daemon: Get "https://registry-1.docker.io/v2/": net/http: TLS handshake timeout

@ChristopherHX
Copy link
Contributor Author

Can we set pull to false to prevent forcePull=true?

You should be able to put...

--pull=false

...into a file called $PWD/.actrc as a new line

Use --bug-report of the act cli to see the operating system specific global file location

Sometimes you will encounter the following error.

I don't remember to have ever seen your error in act.

You can technically just append space + --pull=false to the act command setting...

@SanjulaGanepola
Copy link
Owner

I will be revisiting the current PR we have open (#117) this weekend to better support this.

@ChristopherHX
Copy link
Contributor Author

No open PR from my side implement this, the removal of the default value of type bool during review restored this issue with both experimental act (--list-options) and regular act

...and yes I refused to look into implementing further improvements

@SanjulaGanepola SanjulaGanepola linked a pull request Jan 19, 2025 that will close this issue
3 tasks
@SanjulaGanepola SanjulaGanepola linked a pull request Jan 19, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants