Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT option in fuzzer is not shown if request doesn't contains JWT pattern #26

Closed
preetkaran20 opened this issue Aug 10, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers tech debt

Comments

@preetkaran20
Copy link
Member

preetkaran20 commented Aug 10, 2021

Is your feature request related to a problem? Please describe.
JWT option in fuzzer is not shown if request doesn't contains JWT pattern. There is no indication to the user that why JWT option is unavailable.

Glimpse of issues
image

If JWT pattern was found in the request then:
image

To Reproduce
Go to any request which is not having JWT pattern and then visit the fuzzer screen.

Expected behavior
Add the behavior details that the fuzzer will only show the JWT option if request has the valid jwt format in Readme.md and also help index (we are building this in PR: #25)

@preetkaran20 preetkaran20 added enhancement New feature or request good first issue Good for newcomers tech debt analysis labels Aug 10, 2021
@preetkaran20
Copy link
Member Author

Hi @kingthorin @thc202,

please share your thoughts.

thanks,
Karan

@thc202
Copy link
Contributor

thc202 commented Aug 10, 2021

I don't think we should show the option if it does not apply. This can be documented in the add-on, that you can only fuzz JWT tokens if there's one.

@kingthorin
Copy link
Collaborator

I'm okay with it only showing when applicable.

@preetkaran20
Copy link
Member Author

Thanks @thc202 and @kingthorin for your inputs. Updated the description.

@preetkaran20 preetkaran20 added documentation Improvements or additions to documentation Hacktoberfest and removed analysis labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers tech debt
Projects
None yet
Development

No branches or pull requests

3 participants