Open
Description
- We need to stop assuming ordering of unknowns/ps in tests. I tried to eliminate this in the main library long ago, but there are apparently still some tests that have issues in this regard.
- We should test that
ps
andus
are subsets of systemps
andus
in general, and not test set equality (since MTK may now add extra stuff). When usingstructural_simplify
we need to test vs.us
andobserved
sinceus
can be moved to observed. - Some tests around conservation laws may be incorrect, see Aayush's Slack comment that:
https://github.com/SciML/Catalyst.jl/blob/master/test/upstream/mtk_structure_indexing.jl#L405
This test is incorrect. prob9 has the initial conditions Gamma[1] => 10.0, X1 => 10.0, X2 => 2.0 which are inconsistent since X1 + X2 ~ Gamma[1] (edited)
[9:29](https://julialang.slack.com/archives/C0894545874/p1745501399505049)
The same holds for Gamma[2] => 20.0, Y1 => 3.0, Y2 => 4.0