Mark matrix-free composites as non-concretizable#361
Merged
ChrisRackauckas merged 1 commit intoMay 4, 2026
Conversation
Contributor
Author
|
Codex was used to help prepare and validate this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing
has_concretizationtrait through SciMLOperator wrappers and composites so matrix-free operators are not accidentally treated as materializable matrices.Compositions involving matrix-free
FunctionOperators now reporthas_concretization == false, while matrix-backed/scalar-backed wrappers continue to reporttruerecursively.Motivation
Downstream packages such as OrdinaryDiffEq need to know whether an operator can be safely converted to an
AbstractMatrix. Without this, matrix-free compositions such asFunctionOperator \ DiagonalOperator * FunctionOperatorcan reachconvert(AbstractMatrix, ...)and fail.This is the first PR in a pair for SciML/OrdinaryDiffEq.jl#2078.
Paired OrdinaryDiffEq PR: SciML/OrdinaryDiffEq.jl#3588
Changes
has_concretizationmethods for scalar operators, wrappers, composites, tensor products, andInvertibleOperator.falsefor non-concretizable operators instead of falling through to concretization.Type stability / allocations
This is trait-only dispatch. It avoids eager matrix materialization for matrix-free operators and does not introduce per-application allocation. Existing concrete conversion behavior is preserved for matrix-backed operators.
Tests