deprecate submit command

Author: corevo

packages/selenium-ide/src/__test__/content/record-api.spec.js

@@ -112,13 +112,6 @@ describe('record-api', () => {
       ).toBeUndefined()
     })
 
-    it('keydown on input records submit (on Firefox)', () => {
-      isFirefox.mockReturnValue(true)
-      fireEvent.keyDown(inputElement, enterKey)
-      fireEvent.keyUp(inputElement, enterKey)
-      expect(recordApi.record.mock.calls[1][0]).toEqual('submit')
-    })
-
     it('click on button without type=submit records click', () => {
       const button = window.document.querySelector('button')
       fireEvent.click(button)

packages/selenium-ide/src/__test__/content/record.spec.js

@@ -28,22 +28,6 @@ export const locatorBuilders = new LocatorBuilders(window)
 
 attach(record)
 
-export function _isValidForm(tagName, target) {
-  return !!(
-    tagName == 'form' &&
-    (target.hasAttribute('id') || target.hasAttribute('name')) &&
-    !target.hasAttribute('onsubmit') &&
-    isFirefox()
-  )
-}
-
-export function _recordFormAction(target) {
-  if (target.hasAttribute('id'))
-    record('submit', [['id=' + target.id, 'id']], '')
-  else if (target.hasAttribute('name'))
-    record('submit', [['name=' + target.name, 'name']], '')
-}
-
 Recorder.inputTypes = [
   'text',
   'password',
@@ -90,14 +74,11 @@ Recorder.addEventHandler('type', 'change', function(event) {
             formChk = tempTarget.tagName.toLowerCase()
           }
 
-          if (_isValidForm(formChk, tempTarget)) {
-            _recordFormAction(tempTarget)
-          } else
-            record(
-              'sendKeys',
-              locatorBuilders.buildAll(this.recordingState.enterTarget),
-              '${KEY_ENTER}'
-            )
+          record(
+            'sendKeys',
+            locatorBuilders.buildAll(this.recordingState.enterTarget),
+            '${KEY_ENTER}'
+          )
           this.recordingState.enterTarget = null
         }
         // END
@@ -190,14 +171,11 @@ Recorder.addEventHandler(
               tempTarget = tempTarget.parentElement
               formChk = tempTarget.tagName.toLowerCase()
             }
-            if (_isValidForm(formChk, tempTarget)) {
-              _recordFormAction(tempTarget)
-            } else
-              record(
-                'sendKeys',
-                locatorBuilders.buildAll(this.recordingState.enterTarget),
-                '${KEY_ENTER}'
-              )
+            record(
+              'sendKeys',
+              locatorBuilders.buildAll(this.recordingState.enterTarget),
+              '${KEY_ENTER}'
+            )
             this.recordingState.enterTarget = null
           }
           if (
@@ -225,14 +203,11 @@ Recorder.addEventHandler(
                     tempTarget = tempTarget.parentElement
                     formChk = tempTarget.tagName.toLowerCase()
                   }
-                  if (_isValidForm(formChk, tempTarget)) {
-                    _recordFormAction(tempTarget)
-                  } else
-                    record(
-                      'sendKeys',
-                      locatorBuilders.buildAll(this.recordingState.enterTarget),
-                      '${KEY_ENTER}'
-                    )
+                  record(
+                    'sendKeys',
+                    locatorBuilders.buildAll(this.recordingState.enterTarget),
+                    '${KEY_ENTER}'
+                  )
                   this.recordingState.enterTarget = null
                 }
                 // END

packages/selenium-ide/src/content/record.js

@@ -1478,6 +1478,13 @@ Selenium.prototype.doSubmit = function(formLocator) {
    *
    * @param formLocator an <a href="#locators">element locator</a> for the form you want to submit
    */
+  browser.runtime.sendMessage({
+    log: {
+      type: 'warn',
+      message:
+        'submit is deprecated and will be removed from later versions of Selenium IDE, please re-record the step.',
+    },
+  })
   let form = this.browserbot.findElement(formLocator)
   return bot.action.submit(form)
 }