[AMD][MI35X] 0706 DSV4 sglang mtp#2108
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
4 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28836023139 |
The script sourced ../benchmark_lib.sh, but the lib lives at benchmarks/benchmark_lib.sh (two levels up from fixed_seq_len/), so every lib function (check_env_vars, wait_for_server_ready, run_benchmark_serving, ...) was undefined and the run produced no result JSON (run 28836023139). Matches the ../../benchmark_lib.sh path used by sibling scripts like dsv4_fp4_mi355x_sglang.sh. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
45ce009 to
ff3f169
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28841974603 |
|
@1am9trash https://github.com/SemiAnalysisAI/InferenceX/actions/runs/28841974603/job/85556419336 |
|
This 2 PR may fix the mtp accuracy issue. Will bump the version after daily image build tomorrow. |
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28985274062 |
|
/reuse-sweep-run |
…#2093/sgl-project#2108 Incorporates the following changes from InferenceX benchmark recipes: - Bump MI355X docker image to v0.5.14-rocm720-mi35x-20260708 - Update swa-full-tokens-ratio from 0.1 to 0.15 across all MI355X cells - Add DP-attention env vars for MI355X balanced/high-throughput cells: SGLANG_SHARED_EXPERT_TP1=1, SGLANG_DP_SHARED_EXPERT_LOCAL=1, SGLANG_DP_USE_REDUCE_SCATTER=1 - Replace --enable-prefill-delayer + --prefill-delayer-max-delay-ms 5000 with --enable-two-batch-overlap for all MI355X DP-attention cells Refs: SemiAnalysisAI/InferenceX#2093, SemiAnalysisAI/InferenceX#2108
chunfangamd
left a comment
There was a problem hiding this comment.
As a PR reviewer and CODEOWNER, I have reviewed this and have:
- Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
- Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
- Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this. Link: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/28985274062
- Verified that this PR passes evals. Please link to GitHub Action workflow that shows this. Range: 95.53%-96.13%; link: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/28985274062
- Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
- Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
- If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
- If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
- Verified that the single-node recipes are similar to the official vLLM recipes and/or theSGLang cookbook:
- If they are not, I have verified that a PR has been opened in vLLM recipe repo or SGLang repo and linked it below in the additional detail section:
- If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.
Additional detail section:
- insert any additional info here
SGLang cookbook link: sgl-project/sglang#30651
Signed: @chunfangamd
✅✅✅ Verdict: PASS ✅✅✅✅ Check 0 (CODEOWNER): PASS — @chunfangamd is a listed owner of |
Successful run:
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28985274062
see unofficial run visualizer at https://inferencex.semianalysis.com/evaluation?unofficialRun=28985274062