Skip to content

Commit eecbdf5

Browse files
cursoragentShiosOS
andcommitted
Document pages.js, selector-maintenance workflow, and changelog entries
Co-authored-by: Julius Walton <ShiosOS@users.noreply.github.com>
1 parent 442f1c8 commit eecbdf5

2 files changed

Lines changed: 31 additions & 10 deletions

File tree

CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2222
- A corrupted stored preference value no longer desyncs the toggle label
2323
from the actual sort order; anything unrecognized falls back to newest.
2424

25+
- Status-word matching in the checks indicator uses word boundaries, so a
26+
check _named_ e.g. `failover-suite` or `cancellation-service` that passed
27+
is no longer misreported as failing.
28+
2529
### Added
2630

2731
- Accessible labels (`aria-label`) on the injected toggle button and
2832
status-checks indicator.
2933
- 128px toolbar icon variants wired into the action icon set.
34+
- The popup follows the browser's light/dark preference instead of always
35+
rendering dark.
36+
37+
### Changed
38+
39+
- The per-page GitHub DOM selectors moved from `content.js` into a new
40+
`pages.js` module, and `background.js` became importable under Node —
41+
both are now covered by unit tests (79 tests total), including the page
42+
structures for the Conversation, modern Commits, and legacy Commits
43+
views.
44+
- CI runs on both the minimum supported Node (22) and current (24).
3045

3146
## [1.1.0] - 2026-06-04
3247

README.md

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -115,16 +115,22 @@ source files in this repo as-is. To make a change, edit the source, reload
115115
the extension at `chrome://extensions` (or re-install the temporary add-on
116116
in Firefox), and refresh a PR page.
117117

118-
| File | Purpose |
119-
| --------------- | ----------------------------------------------------- |
120-
| `manifest.json` | Extension definition (Manifest V3, Chrome + Firefox) |
121-
| `constants.js` | Shared constants (storage key, order values) |
122-
| `reorder.js` | Pure DOM-reordering helpers (unit-tested) |
123-
| `checks.js` | PR status-checks detection helpers (unit-tested) |
124-
| `content.js` | Runs on PR pages; reorders comments, draws the toggle |
125-
| `background.js` | Keeps the toolbar icon in sync with the current tab |
126-
| `popup.html` | Toolbar popup UI |
127-
| `popup.js` | Popup behavior; reads/writes saved preference |
118+
| File | Purpose |
119+
| --------------- | --------------------------------------------------------- |
120+
| `manifest.json` | Extension definition (Manifest V3, Chrome + Firefox) |
121+
| `constants.js` | Shared constants (storage key, order values) |
122+
| `reorder.js` | Pure DOM-reordering helpers (unit-tested) |
123+
| `checks.js` | PR status-checks detection helpers (unit-tested) |
124+
| `pages.js` | Per-page GitHub DOM selectors and targets (unit-tested) |
125+
| `content.js` | Runs on PR pages; wires storage, observers, and the UI |
126+
| `background.js` | Keeps the toolbar icon in sync with the tab (unit-tested) |
127+
| `popup.html` | Toolbar popup UI |
128+
| `popup.js` | Popup behavior; reads/writes saved preference |
129+
130+
When GitHub ships a UI change that breaks reordering, the selectors to
131+
update live in `pages.js` (timeline/commits targets) and `checks.js`
132+
(status-checks box); each has jsdom tests with fixtures mirroring the real
133+
page structure, so start by updating the fixture to match the new DOM.
128134

129135
### Dev tooling (optional)
130136

0 commit comments

Comments
 (0)