TOXIPROXY WORKING IN CI 🎉

Author: mrattle

.github/workflows/ci.yml

@@ -35,16 +35,9 @@ jobs:
         image: memcached:latest
         ports:
           - 11211:11211
-      # toxiproxy:
-      #   image: ghcr.io/shopify/toxiproxy:latest
-      #   ports:
-      #     - 8474:8474
-      #     - 40000:11211
-      #     - 40001:11211
-      #     - 40002:11211
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - name: Try running toxiproxy directly in main container
+      - name: Run toxiproxy service in main environment
         run: |
           wget -qO toxiproxy_2.9.0.deb https://github.com/Shopify/toxiproxy/releases/download/v2.9.0/toxiproxy_2.9.0_linux_amd64.deb
           sudo dpkg -i toxiproxy_2.9.0.deb

tests/resiliency_tests.rs

@@ -132,17 +132,9 @@ mod tests {
                 .unwrap()
         });
 
-        println!("toxic_local_url in test 1: {}", toxic_local_addr);
         let mut toxic_client =
             rt.block_on(async { async_memcached::Client::new(toxic_local_url).await.unwrap() });
 
-        let response = rt.block_on(async { clean_client.version().await });
-        println!("test 1 version response from clean client: {:?}", response);
-        assert!(response.is_ok());
-        let response = rt.block_on(async { toxic_client.version().await });
-        println!("test 1 version response from toxic client: {:?}", response);
-        assert!(response.is_ok());
-
         for key in &keys {
             let _ = rt.block_on(async { clean_client.delete(key).await });
             let result = rt.block_on(async { clean_client.get(key).await });
@@ -192,7 +184,6 @@ mod tests {
                 .unwrap()
         });
 
-        println!("toxic_local_url in test 2: {}", toxic_local_addr);
         let mut toxic_client =
             rt.block_on(async { async_memcached::Client::new(toxic_local_url).await.unwrap() });
 
@@ -207,13 +198,6 @@ mod tests {
 
         let byte_limit = multiset_command.len() - 10; // First two commands should be intact, last one cut off
 
-        let response = rt.block_on(async { clean_client.version().await });
-        println!("test 2 version response from clean client: {:?}", response);
-        assert!(response.is_ok());
-        let response = rt.block_on(async { toxic_client.version().await });
-        println!("test 2 version response from toxic client: {:?}", response);
-        assert!(response.is_ok());
-
         let _ = toxic_proxy
             .with_limit_data("upstream".into(), byte_limit as u32, 1.0)
             .apply(|| {
@@ -281,17 +265,9 @@ mod tests {
                 .unwrap()
         });
 
-        println!("toxic_local_url in test 3: {}", toxic_local_addr);
         let mut toxic_client =
             rt.block_on(async { async_memcached::Client::new(toxic_local_url).await.unwrap() });
 
-        let response = rt.block_on(async { clean_client.version().await });
-        println!("test 3 version response from clean client: {:?}", response);
-        assert!(response.is_ok());
-        let response = rt.block_on(async { toxic_client.version().await });
-        println!("test 3 version response from toxic client: {:?}", response);
-        assert!(response.is_ok());
-
         for key in &keys {
             let _ = rt.block_on(async { clean_client.delete(key).await });
             let result = rt.block_on(async { clean_client.get(key).await });