Skip to content

[Swift] Remove preload feature library and sample#173

Merged
tiagocandido merged 1 commit into
mainfrom
05-20-_swift_remove_preload_feature_library_and_sample
May 21, 2026
Merged

[Swift] Remove preload feature library and sample#173
tiagocandido merged 1 commit into
mainfrom
05-20-_swift_remove_preload_feature_library_and_sample

Conversation

@tiagocandido

@tiagocandido tiagocandido commented May 20, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

This PR removes Swift Checkout Kit preload support from the library, sample app, README, and tests.

The change removes the preload entry point, preloading configuration, WebView cache and prefetch-header behavior, preload instrumentation tags, sample controls/calls, and README preload documentation.

How to test

  • ./Scripts/xcode_run test ShopifyCheckoutKit-Package
  • ./Scripts/build_samples
  • ./Scripts/lint check --verbose --skip-pod
  • ./Scripts/ensure_license
  • env BUNDLE_GEMFILE=platforms/swift/Gemfile ruby -rostruct /Users/tiagosantos/.local/state/tec/profiles/base/current/global/bin/bundle exec pod lib lint ShopifyCheckoutKit.podspec --allow-warnings

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

tiagocandido commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.26% (181/190) 92.03% (104/113) 100% (56/56)

@tiagocandido tiagocandido force-pushed the 05-20-_android_remove_recovery_mode branch from 8305170 to ef908e7 Compare May 20, 2026 15:02
@tiagocandido tiagocandido force-pushed the 05-20-_swift_remove_preload_feature_library_and_sample branch 2 times, most recently from 708e77e to 8a65451 Compare May 20, 2026 15:31
@tiagocandido tiagocandido marked this pull request as ready for review May 20, 2026 15:48
@tiagocandido tiagocandido requested a review from a team as a code owner May 20, 2026 15:48

@westeezy westeezy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiagocandido commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 21, 10:56 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 21, 11:16 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 21, 11:29 AM UTC: @tiagocandido merged this pull request with Graphite.

@tiagocandido tiagocandido changed the base branch from 05-20-_android_remove_recovery_mode to graphite-base/173 May 21, 2026 10:57
@tiagocandido tiagocandido changed the base branch from graphite-base/173 to main May 21, 2026 11:14
@tiagocandido tiagocandido force-pushed the 05-20-_swift_remove_preload_feature_library_and_sample branch from 8a65451 to 8e4f802 Compare May 21, 2026 11:15
@tiagocandido tiagocandido merged commit 2b52025 into main May 21, 2026
23 checks passed
@tiagocandido tiagocandido deleted the 05-20-_swift_remove_preload_feature_library_and_sample branch May 21, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants