Add repo setup orchestration commands#176
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d2be551 to
e86923e
Compare
aef7cdc to
ddc5f30
Compare
e86923e to
06f9f45
Compare
ddc5f30 to
3f74a95
Compare
06f9f45 to
0e9dc0f
Compare
3f74a95 to
ee67e70
Compare
0e9dc0f to
8ebd042
Compare
ee67e70 to
5be06e0
Compare
716abfe to
733c680
Compare
5be06e0 to
59ad611
Compare
733c680 to
f8b72c3
Compare
59ad611 to
0fd134c
Compare
f8b72c3 to
5d6ef3d
Compare
0fd134c to
4b6d89e
Compare
5d6ef3d to
575a93a
Compare
4b6d89e to
3946d12
Compare
Juanita-Dash
left a comment
There was a problem hiding this comment.
Review assisted by pair-review
Juanita-Dash
left a comment
There was a problem hiding this comment.
Left 1 suggestion with the help of pair-review. Looks good otherwise.
2bf264d to
4275954
Compare
fd92723 to
3904453
Compare
4275954 to
31ddca1
Compare
3ba3067 to
6e965dd
Compare
3904453 to
44e6880
Compare
6e965dd to
24d84a8
Compare
|
@kiftio @kieran-osgood-shopify Wanted to sanity check the I originally added it so people wouldn’t need to run a full The platform setup commands are partial: they skip DevHub/native provisioning, so the docs still need to say “run
Cached I’m thinking we simplify to:
And remove Repo-owned setup can still run best-effort internally and summarize failures, so one platform issue doesn’t hide everything else. What do you folks think? |
|
Yeah, this makes sense to me 👍 |
24d84a8 to
6c9e707
Compare
| met?: (cd platforms/react-native/sample/ios && bundle check) | ||
| meet: cd platforms/react-native/sample/ios && bundle install | ||
| name: Run Checkout Kit workspace setup | ||
| met?: ./scripts/setup_dev_workspace --check --skip-optional-prompts |
There was a problem hiding this comment.
I made it so the entitlements file is always generated to prevent staleness. Feel free to push back on that.
6c9e707 to
6e38844
Compare
| run_shell "Swift sample entitlements" 'cd platforms/swift && ./Scripts/setup_entitlements' || true | ||
| else | ||
| run_shell "Swift bundle packages" 'BUNDLE_GEMFILE=platforms/swift/Gemfile bundle check || BUNDLE_GEMFILE=platforms/swift/Gemfile bundle install' || true | ||
| run_shell "Swift Mint packages" 'cd platforms/swift && mint bootstrap' || true |
There was a problem hiding this comment.
I removed the conditional Mint version shortcut and now the setup path just runs mint bootstrap directly. The previous check could skip bootstrap if one tool version was stale but the later check passed, so dev up could keep reporting setup as stale without actually fixing it. mint bootstrap is cheap when everything is already current, so this keeps the setup path simpler and more reliable.
44e6880 to
4405d04
Compare
6e38844 to
9d6ffae
Compare
9d6ffae to
d1aa739
Compare
Merge activity
|
d1aa739 to
24458c3
Compare

Depends on #175.
Closes shop/issues-checkout-kit#908.
This PR wires shared storefront configuration into
dev upas the single setup path for the repo. It addsscripts/setup_dev_workspace, uses it from the rootdev up, and keeps platform commands focused on post-setup work like build, test, lint, format, run, clean, and API checks.The repo-owned setup step syncs sample app storefront configuration from the root
.env, refreshes Swift sample entitlements fromStorefront.xcconfig, installs/checks platform dependencies, and prints a summary so setup failures are visible without hiding later platform results. The public setup surface stays intentionally small: rundev upto get the repo ready, then usedev <platform> <command>for platform-specific work.How to test
Note: There is a follow-up opportunity to move the setup/config parsing logic out of ad hoc Bash and into a small reusable dev utilities area for this monorepo. In particular, helpers for reading
.env/.xcconfigvalues across packages could make these setup scripts easier to maintain and compose. This PR keeps the current command surface focused and tested, and leaves that implementation cleanup for a separate review. Issue created here.