Rename React Native demo app#240
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/react-native
branch
from
63b10f0 to
81660cb
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/android
branch
2 times, most recently
from
0528771 to
9d68ebd
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/react-native
branch
2 times, most recently
from
4237c17 to
21d5978
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/android
branch
2 times, most recently
from
14934c9 to
87ff6fa
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/react-native
branch
from
21d5978 to
5b460e9
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/android
branch
from
87ff6fa to
cc6e410
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/react-native
branch
from
5b460e9 to
6dafdba
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/react-native
branch
from
6dafdba to
efe6670
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/rename-demo-apps/android
branch
from
cc6e410 to
0d05e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This 3-PR stack renames the platform sample/demo apps to consistently use the
CheckoutKit<Platform>Demonaming pattern and aligns their bundle/application identifiers with those demo names:MobileBuyIntegration→CheckoutKitSwiftDemoMobileBuyIntegration→CheckoutKitAndroidDemoReactNative→CheckoutKitReactNativeDemoWhat?
Renames the React Native sample app's app registry name, Android package/application id, iOS project/target/scheme/workspace, app labels, scripts, and CocoaPods target metadata to
CheckoutKitReactNativeDemo.Also updates the React Native demo app identifiers to match the new name:
com.shopify.checkoutkit.reactnativedemocom.shopify.checkoutkit.reactnativedemocom.shopify.checkoutkit.reactnativedemo.testsmerchant.com.shopify.checkoutkit.reactnativedemoWhy?
The generic
ReactNativeapp name was inconsistent with the platform-specific Checkout Kit demo names introduced lower in the stack. This makes the React Native sample clearly identifiable alongside the Swift and Android demos.Validation
cd platforms/react-native && LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 pnpm run pod-installcd platforms/react-native/sample/android && ./gradlew testDebugUnitTestxcodebuild -list -workspace platforms/react-native/sample/ios/CheckoutKitReactNativeDemo.xcworkspacecd platforms/react-native && pnpm --filter sample typecheck