Skip to content

Commit 10ffab5

Browse files
Fix breaking-change-check: restore fetch-depth: 0 for merge-base diff
Moving the job into its own workflow file accidentally dropped fetch-depth from 0 to 1. Without full history, `git merge-base origin/<base> HEAD` fails and the scoping logic falls back to scanning all changesets/schemas, re-flagging every pre-existing major change in the repo.
1 parent 27d7554 commit 10ffab5

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

‎.github/workflows/breaking-change-check.yml‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,12 @@ jobs:
4343
with:
4444
repository: ${{ github.event.pull_request.head.repo.full_name || github.event.repository.full_name }}
4545
ref: ${{ github.event.pull_request.head.sha || github.event.merge_group.head_sha }}
46-
fetch-depth: 1
46+
# Full history so `git merge-base origin/<base> HEAD` (used by
47+
# major-change-check.js to scope the diff to PR-only changes) can
48+
# reach the divergence point. With fetch-depth: 1 the merge-base
49+
# call fails and the script falls back to scanning everything,
50+
# surfacing every pre-existing major changeset as "new".
51+
fetch-depth: 0
4752
- name: Setup deps
4853
uses: ./.github/actions/setup-cli-deps
4954
with:

0 commit comments

Comments
 (0)