Skip to content

Commit 24f882f

Browse files
Remove the ESLint compatibility layer
1 parent db1f796 commit 24f882f

118 files changed

Lines changed: 1705 additions & 6377 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/tests-main.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ jobs:
5151
- name: Oxlint
5252
run: pnpm lint:oxlint
5353
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
54-
- name: ESLint compatibility
55-
run: pnpm lint:eslint --output-style=stream
56-
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}
5754
- name: Type-check
5855
run: pnpm nx run-many --all --target=type-check --output-style=stream
5956
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '26.1.0' }}

‎.github/workflows/tests-pr.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ jobs:
5555
run: pnpm prettier
5656
- name: Oxlint
5757
run: pnpm lint:oxlint
58-
- name: ESLint compatibility
59-
run: pnpm lint:eslint --output-style=stream
6058

6159
bundle:
6260
name: 'Bundle'

‎.gitignore‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ web_modules/
5555
# Optional npm cache directory
5656
.npm
5757

58-
# Optional eslint cache
59-
.eslintcache
60-
6158
# Optional stylelint cache
6259
.stylelintcache
6360

@@ -175,9 +172,6 @@ testing.mjs
175172
# NX
176173
.nx
177174

178-
# ESLint reports
179-
eslint-report.json
180-
181175
# Generated docs
182176
docs/api
183177
docs-shopify.dev/commands/interfaces/

‎.vscode/extensions.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"recommendations": ["esbenp.prettier-vscode","dbaeumer.vscode-eslint","nrwl.angular-console","vitest.explorer"]
2+
"recommendations": ["esbenp.prettier-vscode", "oxc.oxc-vscode", "nrwl.angular-console", "vitest.explorer"]
33
}

‎.vscode/settings.json‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"**/node_modules": true
2222
},
2323
"editor.formatOnSave": false,
24-
"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
24+
"oxc.enable": true,
2525
"[javascript]": {
2626
"editor.formatOnSave": true,
2727
"editor.defaultFormatter": "esbenp.prettier-vscode"
@@ -31,9 +31,8 @@
3131
"editor.defaultFormatter": "esbenp.prettier-vscode"
3232
},
3333
"editor.codeActionsOnSave": {
34-
"source.fixAll.eslint": "explicit"
34+
"source.fixAll.oxc": "explicit"
3535
},
36-
"eslint.workingDirectories": [{ "pattern": "packages/*" }],
3736
"vitest.enable": true,
3837
"testing.automaticallyOpenPeekView": "never",
3938
"javascript.preferences.importModuleSpecifierEnding": "js",

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ If the change is not ready to be public, do not add a changeset.
5454
- [docs/cli/conventions.md](docs/cli/conventions.md)
5555
- [docs/cli/cross-os-compatibility.md](docs/cli/cross-os-compatibility.md)
5656
- [docs/cli/debugging.md](docs/cli/debugging.md)
57-
- [docs/cli/eslint-rules.md](docs/cli/eslint-rules.md)
57+
- [docs/cli/oxlint-rules.md](docs/cli/oxlint-rules.md)
5858
- [docs/cli/faq.md](docs/cli/faq.md)
5959
- [docs/cli/get-started.md](docs/cli/get-started.md)
6060
- [docs/cli/naming-conventions.md](docs/cli/naming-conventions.md)

‎docs/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ The list below contains valuable resources for people interested in contributing
1515
* [Conventions](./cli/conventions.md)
1616
* [Performance](./cli/performance.md)
1717
* [Debugging](./cli/debugging.md)
18-
* [ESLint rules](./cli/eslint-rules.md)
18+
* [Oxlint rules](./cli/oxlint-rules.md)
1919
* [Testing strategy](./cli/testing-strategy.md)
2020
* [Cross-OS compatibility](./cli/cross-os-compatibility.md)
2121
* [Troubleshooting](./cli/troubleshooting.md)

‎docs/cli/get-started.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ Besides the scripts for building and running the CLIs, there are others that mig
7070
- `pnpm test`: Runs the tests of all the packages.
7171
- `pnpm prettier`: Checks formatting for all linted source files.
7272
- `pnpm prettier:fix`: Formats all linted source files.
73-
- `pnpm lint`: Runs Prettier, Oxlint, and ESLint compatibility checks for all the packages.
74-
- `pnpm lint:fix`: Runs Prettier, Oxlint, and ESLint compatibility checks and fixes supported issues.
73+
- `pnpm lint`: Runs Prettier and Oxlint checks for all the packages.
74+
- `pnpm lint:fix`: Runs Prettier and Oxlint and fixes supported issues.
7575
- `pnpm type-check`: Type-checks all the packagesusing the Typescript `tsc` tool.
7676
- `pnpm clean`: Removes the `dist` directory from all the packages.
7777

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# ESLint Rules
1+
# Oxlint Rules
22

3-
To ensure the contributions to the project follow the conventions,
4-
the project leverages [ESLint](https://eslint.org/) with third-party and local rules.
5-
This page contains a list of all the local rules alongside the convention they enforce.
3+
To ensure contributions follow the project's conventions, the project uses
4+
[Oxlint](https://oxc.rs/docs/guide/usage/linter.html) with native and local rules.
5+
This page lists the local rules and the conventions they enforce.
66

77
### `command-flags-with-env`
88

‎eslint.codegen.config.js‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)