Skip to content

Commit 544ead1

Browse files
Emit native absolute paths at JSON output boundaries
1 parent 0af2d0a commit 544ead1

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎packages/theme/src/cli/commands/theme/check-json.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@ import {encodeThemeCheckResult} from '../../services/check/result.js'
55
import {expect, test, vi} from 'vitest'
66
import {withCapturedStandardStreams} from '@shopify/cli-kit/node/testing/output'
77
import {themeCheckRun, Severity, SourceCodeType, path as pathUtils} from '@shopify/theme-check-node'
8-
import {resolvePath} from '@shopify/cli-kit/node/path'
98
import {inTemporaryDirectory} from '@shopify/cli-kit/node/fs'
109
import {runWithCommandEventsForCommand} from '@shopify/cli-kit/node/command-events'
10+
// Native JSON paths must preserve Windows separators instead of pathe normalization.
11+
// eslint-disable-next-line no-restricted-imports
12+
import {resolve as resolvePath} from 'node:path'
1113

1214
vi.mock('@shopify/theme-check-node', async (importOriginal) => ({
1315
...(await importOriginal<typeof import('@shopify/theme-check-node')>()),

‎packages/theme/src/cli/services/check/types.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import {defineThemeJsonOutputSchema} from '../json-output/schema.js'
22
import {zod} from '@shopify/cli-kit/node/schema'
3-
import {isAbsolutePath, resolvePath} from '@shopify/cli-kit/node/path'
3+
import {isAbsolutePath} from '@shopify/cli-kit/node/path'
4+
// Native JSON paths must preserve Windows separators instead of pathe normalization.
5+
// eslint-disable-next-line no-restricted-imports
6+
import {resolve as resolvePath} from 'node:path'
47

58
const ThemeCheckIssueSchema = zod
69
.object({

0 commit comments

Comments
 (0)