Merge pull request #7830 from Shopify/downgrade-oclif

Pin oclif to 4.8.3

Author: gonzaloriestra

packages/app/package.json

@@ -60,7 +60,7 @@
   "dependencies": {
     "@graphql-typed-document-node/core": "3.2.0",
     "@luckycatfactory/esbuild-graphql-loader": "3.8.1",
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@shopify/cli-kit": "4.1.0",
     "@shopify/plugin-cloudflare": "4.1.0",
     "@shopify/organizations": "4.1.0",

packages/cli-kit/package.json

@@ -106,7 +106,7 @@
     "@bugsnag/js": "8.9.0",
     "@graphql-typed-document-node/core": "3.2.0",
     "@iarna/toml": "2.2.5",
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@shopify/polaris": "12.27.0",
     "@shopify/polaris-icons": "8.11.1",
     "@shopify/toml-patch": "0.3.0",

packages/cli-kit/src/public/node/cli-launcher.test.ts

@@ -1,5 +1,7 @@
 import {launchCLI} from './cli-launcher.js'
-import {describe, expect, test} from 'vitest'
+import {ShopifyConfig} from './custom-oclif-loader.js'
+import {run} from '@oclif/core'
+import {describe, expect, test, vi} from 'vitest'
 
 describe('launchCLI', () => {
   test('launches the CLI successfully with help flag', async () => {
@@ -11,4 +13,23 @@ describe('launchCLI', () => {
   test('fails if args are invalid', async () => {
     await expect(launchCLI({moduleURL: import.meta.url, argv: ['this', 'is', 'invalid']})).rejects.toThrow()
   })
+
+  test('preserves the loaded Shopify config so commands can be loaded lazily', async () => {
+    const command = {id: 'lazy-test'} as any
+    const config = new ShopifyConfig({root: import.meta.url})
+    const lazyCommandLoader = vi.fn().mockResolvedValue({
+      run: vi.fn().mockResolvedValue('ok'),
+    })
+
+    config.setLazyCommandLoader(lazyCommandLoader)
+    config.findCommand = vi.fn().mockReturnValue(command)
+    config.runHook = vi.fn().mockResolvedValue({successes: [], failures: []})
+    config.pjson = {oclif: {}} as any
+    config.userAgent = '@shopify/cli-kit/test'
+
+    await expect(run(['lazy-test'], config)).resolves.toBe('ok')
+
+    expect(lazyCommandLoader).toHaveBeenCalledWith('lazy-test')
+    expect(config.findCommand).toHaveBeenCalledWith('lazy-test')
+  })
 })

packages/cli/package.json

@@ -57,7 +57,7 @@
     "global-agent": "3.0.0"
   },
   "devDependencies": {
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@oclif/plugin-commands": "4.1.57",
     "@oclif/plugin-plugins": "5.4.47",
     "@shopify/app": "4.1.0",

packages/plugin-cloudflare/package.json

@@ -45,7 +45,7 @@
     ]
   },
   "dependencies": {
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@shopify/cli-kit": "4.1.0"
   },
   "devDependencies": {

packages/plugin-did-you-mean/package.json

@@ -40,7 +40,7 @@
     ]
   },
   "dependencies": {
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@shopify/cli-kit": "4.1.0",
     "n-gram": "2.0.2"
   },

packages/store/package.json

@@ -40,7 +40,7 @@
   },
   "dependencies": {
     "@graphql-typed-document-node/core": "3.2.0",
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@shopify/cli-kit": "4.1.0",
     "@shopify/organizations": "4.1.0"
   },

packages/theme/package.json

@@ -40,7 +40,7 @@
     ]
   },
   "dependencies": {
-    "@oclif/core": "4.11.4",
+    "@oclif/core": "4.8.3",
     "@shopify/cli-kit": "4.1.0",
     "@shopify/theme-check-node": "3.26.1",
     "@shopify/theme-language-server-node": "2.21.3",